Equeue chaining bug fixes #9066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2018 16:24
report error / assert when allocation fails.
Issue was seen with below example
EventQueue q1;
EventQueue q2;
void main() {
while( true ) {
q1.chain( &q2 ); // Chain q2 to q1
q1.chain( NULL ); // Remove chain from q1
//This second step should free the memory from the chained q2 event.
}
}
Memory allocated from q1 slab was freed for q2, which will result in
memory leak.
kjbracey
suggested changes
Dec 13, 2018
|
@ARMmbed/mbed-os-maintainers - API was updated to return error codes. Should be considered for minor release. |
cmonr
added
BREAKING-CHANGE
release-version: 5.12.0-rc1
and removed
BREAKING-CHANGE
labels
kjbracey
reviewed
Dec 14, 2018
deepikabhavnani
force-pushed
the
equeue_chain_fixed
branch
from
fcf4758
to
87c557c
Compare
Patch or minor, will leave the decision to @ARMmbed/mbed-os-maintainers |
kjbracey
approved these changes
Dec 14, 2018
|
Updated for a patch. The changing return types are necessary for the fix, and the risk for these updated return types is low. |
|
@geky @SenRamakri - Please review |
geky
approved these changes
Dec 21, 2018
SenRamakri
reviewed
Dec 21, 2018
SenRamakri
approved these changes
Dec 21, 2018
|
CI started |
Test run: FAILEDSummary: 1 of 1 test jobs failed Failed test jobs:
|
Fixed in 14606b5 |
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issues reported in #8567
Pull request type
CC @geky @marcemmers