Modify IRQ handler processing when unusing RTOS at Cortex-A #9167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of unusing RTOS, IRQ handler executes "while(1)" and it causes a program freeze. Therefore, I revised this processing. Also I added the heap setting processing and set the align to 8 byte.
In case of unusing RTOS, IRQ handler executes "while(1)" and it causes a program freeze. Therefore, I revised this processing.
In case of unusing RTOS, there is no processing against IRQ handler and it causes a linker error. Therefore, I added this processing with WEAK attribute. Also I added cmain.S file at cmsis/TARGET_CORTEX_A folder.
|
@TomoYamanaka, thank you for your changes. |
|
cc @toyowata |
|
@ARMmbed/mbed-os-core Please review some new cmsis files (cmsis/TARGET_CORTEX_A/TOOLCHAIN_IAR/cmain.S and similar) |
bulislaw
approved these changes
Dec 24, 2018
|
@SenRamakri - Please review |
0xc0170
approved these changes
Jan 2, 2019
| return r; | ||
| } | ||
|
|
||
| #if !defined(MBED_CONF_RTOS_PRESENT) || !MBED_CONF_RTOS_PRESENT |
There was a problem hiding this comment.
should just check for the value (!defined not needed)
|
@0xc0170 I updated my commit. Make a sense? |
|
@ARMmbed/mbed-os-core When y'all get a chance, this looks to be about ready (we can restart CI if issues are found). |
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I modified the IRQ handler processing when unusing RTOS feature(ex:
mbed-bootloader-extended) at Cortex-A.In case of ARMCC and GCC:
"while (1)" processing is executed as a default, it causes a program freeze.
In case of IAR:
There is no corresponded processing, it causes a linker error.
Thus, I modified or added IRQ handler with WEAK attribute.
In addition,
in ARMCC, I added heap setting processing because there is no this setting processing, and set the align to 8 byte.
in IAR, I added cmain.S file at cmsis/TARGET_CORTEX_A folder for working constructor processing correctly.
Pull request type