Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assertion of MDMRST in case of SARA-R4 #9902

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Remove assertion of MDMRST in case of SARA-R4 #9902

merged 1 commit into from
Mar 14, 2019

Conversation

wajahat-abbas
Copy link
Member

Description

In case of SARA-R4, MDMRST needs to be asserted for 10 seconds before modem actually powers down. This means that modem is initially responsive to AT commands but powers down after 10 seconds unless MDMRST is de-asserted (a call to onboard_modem_init() ). This can create confusion for application as CellularDevice::is_ready() will return TRUE initially and ten seconds later modem will power off without any indication to the application.

This can also cause test cases to fail that rely on system_reset() for MCU reboot. In such case, Cellular state machine will get an OK response from CellularDevice::is_ready() so it will not call the power_on() methods and resume its states however after 10 seconds, modem will power down possibly leaving state machine in an undesired state or leading to failure of test case.

We have evaluated others options to fix this problem and have decided not to assert MDMRST in our start-up code. Other options require us to wait 10 seconds at each reset which is not reasonable.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@wajahat-abbas wajahat-abbas changed the title Do not assert MDMRST in case of SARA-R4 Remove assertion of MDMRST in case of SARA-R4 Mar 1, 2019
@ciarmcom ciarmcom requested review from screamerbg and a team March 1, 2019 12:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 1, 2019

@wajahat-ublox, thank you for your changes.
@screamerbg @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 8, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 9, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 1bbf7d6 into ARMmbed:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants