Remove assertion of MDMRST in case of SARA-R4 #9902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case of SARA-R4, MDMRST needs to be asserted for 10 seconds before modem actually powers down. This means that modem is initially responsive to AT commands but powers down after 10 seconds unless MDMRST is de-asserted (a call to
onboard_modem_init()
). This can create confusion for application asCellularDevice::is_ready()
will returnTRUE
initially and ten seconds later modem will power off without any indication to the application.This can also cause test cases to fail that rely on
system_reset()
for MCU reboot. In such case, Cellular state machine will get an OK response fromCellularDevice::is_ready()
so it will not call thepower_on()
methods and resume its states however after 10 seconds, modem will power down possibly leaving state machine in an undesired state or leading to failure of test case.We have evaluated others options to fix this problem and have decided not to assert MDMRST in our start-up code. Other options require us to wait 10 seconds at each reset which is not reasonable.
Pull request type
Reviewers
Release Notes