Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct FPU settings traceback found by IAR #9994

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Correct FPU settings traceback found by IAR #9994

merged 1 commit into from
Mar 14, 2019

Conversation

theotherjimmy
Copy link
Contributor

Description

Fixes #9974

The error was that the Asymmetric CPUs were assumed to have the same
structure as the Symmetric CPUs. This is clearly false.

This PR changes the FPU detection of Asymmetric CPUs to find the correct
core and use it's cpu settings.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@theotherjimmy
Correct FPU settings traceback found by IAR
35479e8 
Fixes ARMmbed#9974

The error was that the Asymmetric CPUs were assumed to have the same
structure as the Symmetric CPUs. This is clearly false.

This PR changes the FPU detection of Asymmetric CPUs to find the correct
core and use it's cpu settings.

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Docs update
    [ ] Test update
    [ ] Breaking change
@cmonr cmonr requested a review from 0xc0170 March 7, 2019 20:09
@mmahadevan108 mmahadevan108 mentioned this pull request Mar 12, 2019
Merged
@mikisch81
Copy link
Contributor

@ARMmbed/mbed-os-maintainers Is it possible to move this to rc3, now that #10068 needs it?

@0xc0170 0xc0170 requested a review from a user March 13, 2019 09:45
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 13, 2019

@ARMmbed/mbed-os-maintainers Is it possible to move this to rc3, now that #10068 needs it?

release request done, will wait for approval

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 13, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 13, 2019

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM

@theotherjimmy
Copy link
Contributor Author

No failures in the build artifacts. @0xc0170 What went wrong?

@cmonr
Copy link
Contributor

cmonr commented Mar 13, 2019

Woah.

java.io.IOException: Server returned HTTP response code: 502 for URL: https://api.github.com/repos/ARMmbed/mbed-os/statuses/35479e8111ea1000b81d080e8784a3c8d32684b9
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1894)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1492)
	at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480)
	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:347)
	at org.kohsuke.github.Requester.parse(Requester.java:607)

This was inside of the job itself.

@cmonr
Copy link
Contributor

cmonr commented Mar 13, 2019

CI restarted.

@mbed-ci
Copy link

mbed-ci commented Mar 13, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@cmonr
Copy link
Contributor

cmonr commented Mar 13, 2019 •
edited
Loading

armclang: error: Failed to check out a license.

Restarted the export job...

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 14, 2019

@theotherjimmy TODO in the code, can we have this rather as an issue?

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 14, 2019

As this fixes exporters on nightly on 5.12

LGTM

@0xc0170 0xc0170 merged commit 4c7fc65 into ARMmbed:master Mar 14, 2019
@theotherjimmy
Copy link
Contributor Author

I can open an issue for it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@theotherjimmy @mikisch81 @0xc0170 @mbed-ci @cmonr