VSCode Extension #70

granawkins · 2023-08-22T03:30:13Z

Implement Mentat as a Visual Studio Code extension. Basic functionality:

Add a "Mentat" tab in VSCode which opens a new vscode webview
Page 1: Select files and click a start button
Page 2: A standard chat interface for the cli workflow, with buttons for interrupt and restart (back to Page 1)

See /vscode/README.md for setup instructions.

…late into /vscode

contains required files to build/launch extension

VSCode Extension Skeleton

Extension buildout

biobootloader · 2023-08-26T00:26:18Z

@waydegg want to help review this? It's waiting on me to finish #74 , but it'd be good to have you eyes on the VS Code extension implementation

biobootloader · 2023-08-26T21:10:56Z

I wonder if the LSP portion (vscode/bundled/tool/lsp_server.py) could be general enough to support other editor extensions at some point, like for NeoVim?

waydegg · 2023-08-27T01:50:41Z

@granawkins do you have any references to VSCode plugins made with Svelte that are somewhat popular/high-quality that you like? Asking since I've never used Svelte before and wanted to see how other plugins do it.

waydegg · 2023-08-27T02:19:04Z

Need to find a way to make the UI work well with light themes:

waydegg · 2023-08-27T02:26:43Z

I'm a big fan of what Cursor is doing for their chat UI/UX. Any thoughts on this?

They have some good feedback in their Discord on what people have liked/disliked too.

waydegg · 2023-08-27T02:43:01Z

Is this just blocked on #74? Happy to review but I also don't wanna add a bunch of comments per-maturely if you're still making big additions/edits :) Pretty dope to see this working in VSCode btw!

biobootloader · 2023-08-27T18:19:56Z

Is this just blocked on #74? Happy to review but I also don't wanna add a bunch of comments per-maturely if you're still making big additions/edits :)

@waydegg yes #74 needs to be merged first. The big open question is the best way to run both Mentat and the Python side of the LSP defined here - should we set up an async loop that runs both? Run on different processes?

I'm a big fan of what Cursor is doing for their chat UI/UX. Any thoughts on this?

Looks nice! My hope for this PR is to get a working Mentat experience in VS Code that we can then iterate on. So higher level comments on the best way to set this up are most useful. We should also track interface feature ideas somewhere, feel free to create issues for individual ideas or maybe we can start a list somewhere.

granawkins · 2023-08-27T23:11:57Z

I wonder if the LSP portion (vscode/bundled/tool/lsp_server.py) could be general enough to support other editor extensions at some point, like for NeoVim?

Absolutely, that's what I was thinking too. That's how Rift does it. Since this is from a template I figure we leave it like this for now, and if/when we add NeoVim we can separate it out.

@granawkins do you have any references to VSCode plugins made with Svelte that are somewhat popular/high-quality that you like? Asking since I've never used Svelte before and wanted to see how other plugins do it.

Yes - the main one is Rift. I also noticed it in some templates last week which I'm afraid I've lost. There are a few others if you search GitHub for vscode language:svelte.

I'm not married to Svelte though, it's my first time using it as well. It's really similar to Vue, which I've used a lot, but the bundle is lighter and it builds really fast. Open to suggestions.

Need to find a way to make the UI work well with light themes:

Ya, that's top of my list :) Cursor looks awesome - I'm going to try to just get something basic up to start, but love that direction.

Is this just blocked on #74? Happy to review but I also don't wanna add a bunch of comments per-maturely if you're still making big additions/edits :) Pretty dope to see this working in VSCode btw!

The VSCode side is close to ready - go ahead and comment as much as you'd like. If you have a lot of comments/questions it might be easier just to do a videocall? HMU @waydegg

waydegg · 2023-08-31T02:05:16Z

The big open question is the best way to run both Mentat and the Python side of the LSP defined here - should we set up an async loop that runs both? Run on different processes?

I think we should def be building towards running everything async (electron already eats up enough processing as is haha). pygls, the library the VSCode extension template uses that interfaces w/ language servers, has first-class async support. Most of Mentat latency is network io also.

Would love you hear what you guys are thinking.

waydegg · 2023-08-31T02:07:36Z

I'm not married to Svelte though, it's my first time using it as well. It's really similar to Vue, which I've used a lot, but the bundle is lighter and it builds really fast. Open to suggestions.

I'm not married to any particular framework either (I've been wanting an excuse to learn Svelte anyways haha). I guess my only concern would be ease-of-contributing since most ppl already know React/Vue and there's obv a huge library ecosystem for both frameworks.

waydegg · 2023-08-31T02:25:05Z

At a high level I think this looks good! I'll create a github discussion/issue for feature suggestions we can all collaborate on. Happy to review and approve once #74 is merged

jakethekoenig

Two notes around latency. I don't think either need to be addressed in this PR (though one is quick to fix) but I wanted to flag them for later.

Also are we sure we want this as a sub-directory in the mentat repo? I guess if the VSCode and NeoVim plugins end up sharing code it'll be simplest. But it will interfere with the standard way of installing vim plugins: cloning a repo into a plugin directory.

jakethekoenig · 2023-09-01T14:46:56Z

vscode/src/svelte/components/file/File.svelte

+  </div>
+
+  <div class="children-container {isOpen ? 'open' : ''}">
+    {#if file.children}


I notice a ~1 second latency when toggling expand/contract for large directories which can be fixed by checking isOpen here.

jakethekoenig · 2023-09-01T14:50:21Z

vscode/src/svelte/components/file/FileTreeElement.ts

+    constructor(
+        public file: WorkspaceGraphElement, // File metadata
+    ) {
+        if (this.file.children) {


For me there's an ~11s time to load after clicking the refresh button on this project (with python and node dependencies installed). Moving this to handleClick and loading files lazily cut it to ~3s.

Aha - great idea. I've now done something a bit different but same principle.

Your approach is really clean. Nice!

jakethekoenig · 2023-09-01T15:21:52Z

Interesting: rift already included mentat as an agent.
Also @waydegg I don't see a cursor discord. Do you mean their forum?

biobootloader · 2023-09-01T22:55:15Z

Also are we sure we want this as a sub-directory in the mentat repo? I guess if the VSCode and NeoVim plugins end up sharing code it'll be simplest. But it will interfere with the standard way of installing vim plugins: cloning a repo into a plugin directory.

@granawkins and I were talking about this - the benefit of a shared repo is it's easier to coordinate versions and changes between "core" Mentat and the VS Code extension. We do want any code that would be shared by VS Code and NeoVim plugins here (and those bits would probably be useful as well for the community if they make extensions for other editors). @jakethekoenig is the way you see it interfering with vim plugin install just that the cloned repo would be bigger?

Overall my vote is we keep it here for now and see how it goes, but that's not a strong opinion

Interesting: rift already included mentat as an agent.

Just announced today! They way they've included it involves inserting callbacks into the code / patching some input / output functions. When we finish getting Mentat setup for multiple interfaces they'll have an easier time connecting to it.

Also @waydegg I don't see a cursor discord. Do you mean their forum?

They have a discord but looks like they disabled invites for it and are switching to the forum

Extension buildout

@jakethekoenig

speedups suggested by @jakethekoenig

jakethekoenig · 2023-09-04T11:25:14Z

Also are we sure we want this as a sub-directory in the mentat repo? I guess if the VSCode and NeoVim plugins end up sharing code it'll be simplest. But it will interfere with the standard way of installing vim plugins: cloning a repo into a plugin directory.

@granawkins and I were talking about this - the benefit of a shared repo is it's easier to coordinate versions and changes between "core" Mentat and the VS Code extension. We do want any code that would be shared by VS Code and NeoVim plugins here (and those bits would probably be useful as well for the community if they make extensions for other editors). @jakethekoenig is the way you see it interfering with vim plugin install just that the cloned repo would be bigger?

I have two concerns:

Yeah it would make the cloned repo bigger. I guess that's not actually a big concern because storage/bandwidth is cheap and if becomes one we can make instruct the users to use use git clone --filter and git sparse-checkout to just get what they need. Though it's complicated because normally if I wanted to instruct a user to do something non trivial I'd put it in a script for them to run but if they have access to the script they've already cloned the repo.
Vim plugins expect their files in a specific structure so we may have to litter the root of the project with autoload, doc, plugin and syntax and won't be able to bunch them all up under vim. I suppose there's no need to handle vscode and vim in the same way so we could have the vim plugin be a git submodule but the vscode plugin be a subdirectory like it is now.

Sorry if this is getting off topic for this PR.

waydegg · 2023-10-23T16:48:42Z

Closing this b/c of #213

granawkins and others added 16 commits August 16, 2023 11:14

clone https://github.com/microsoft/vscode-python-tools-extension-temp…

d13a4e9

…late into /vscode

overwrite placeholder names, per README

be23f9f

barebones js interface

073f810

register commands to vscode

415e751

mentat commands to/from server

569b146

create dummy MentatRunner

1408c77

update nox script to add mentat code and dependencies to bundle

4a7050f

bundle tiktoken wheels and install with extension

c3a17bb

basic streaming responses

6e3bd78

add .vscode directory to repo

c84d930

contains required files to build/launch extension

replace vanilla js with svelte

d3c0994

updates required to build package

58f21fa

Add path-selection workflow

944f640

clean up repo

971b31c

Merge remote-tracking branch 'upstream/main' into vscode-extension

fdb0864

Merge pull request #1 from granawkins/vscode-extension

805e63a

VSCode Extension Skeleton

granawkins marked this pull request as draft August 22, 2023 03:30

granawkins changed the title ~~VSCode Extension (DRAFT)~~ VSCode Extension Aug 22, 2023

granawkins added 5 commits August 23, 2023 12:16

Serve extension with livereload in browser

a9730b1

setup LanguageServer tests with pytest

a4996f2

add typescript mentat/svelte files

a3ac4a5

change "paths" to "files"

a728c5e

styling

6a10fac

This was referenced Aug 24, 2023

Separate Core Logic from Terminal Interface #63

Closed

Separate Core Logic from Terminal Interface #74

Closed

granawkins and others added 2 commits August 25, 2023 17:03

recursive file selector

61e2dbe

Merge pull request #2 from granawkins/extension-buildout

5bd1873

Extension buildout

biobootloader requested a review from waydegg August 26, 2023 00:26

format fixes

25bb84e

jakethekoenig reviewed Sep 1, 2023

View reviewed changes

granawkins and others added 5 commits September 2, 2023 11:57

fix formatting for light themes

d8ce575

apply .gitignore(s) to FileSelector

aae3b56

Merge pull request #3 from granawkins/extension-buildout

567ce7a

Extension buildout

speedups suggested by @jakethekoenig

e96fe1e

Merge pull request #4 from granawkins/speedups

58a09ba

speedups suggested by @jakethekoenig

waydegg closed this Oct 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VSCode Extension #70

VSCode Extension #70

granawkins commented Aug 22, 2023

biobootloader commented Aug 26, 2023

biobootloader commented Aug 26, 2023

waydegg commented Aug 27, 2023

waydegg commented Aug 27, 2023

waydegg commented Aug 27, 2023

waydegg commented Aug 27, 2023

biobootloader commented Aug 27, 2023

granawkins commented Aug 27, 2023 •

edited

Loading

waydegg commented Aug 31, 2023

waydegg commented Aug 31, 2023

waydegg commented Aug 31, 2023 •

edited

Loading

jakethekoenig left a comment

jakethekoenig Sep 1, 2023

jakethekoenig Sep 1, 2023

granawkins Sep 2, 2023

jakethekoenig Sep 4, 2023

jakethekoenig commented Sep 1, 2023

biobootloader commented Sep 1, 2023

jakethekoenig commented Sep 4, 2023

waydegg commented Oct 23, 2023

VSCode Extension #70

VSCode Extension #70

Conversation

granawkins commented Aug 22, 2023

biobootloader commented Aug 26, 2023

biobootloader commented Aug 26, 2023

waydegg commented Aug 27, 2023

waydegg commented Aug 27, 2023

waydegg commented Aug 27, 2023

waydegg commented Aug 27, 2023

biobootloader commented Aug 27, 2023

granawkins commented Aug 27, 2023 • edited Loading

waydegg commented Aug 31, 2023

waydegg commented Aug 31, 2023

waydegg commented Aug 31, 2023 • edited Loading

jakethekoenig left a comment

Choose a reason for hiding this comment

jakethekoenig Sep 1, 2023

Choose a reason for hiding this comment

jakethekoenig Sep 1, 2023

Choose a reason for hiding this comment

granawkins Sep 2, 2023

Choose a reason for hiding this comment

jakethekoenig Sep 4, 2023

Choose a reason for hiding this comment

jakethekoenig commented Sep 1, 2023

biobootloader commented Sep 1, 2023

jakethekoenig commented Sep 4, 2023

waydegg commented Oct 23, 2023

granawkins commented Aug 27, 2023 •

edited

Loading

waydegg commented Aug 31, 2023 •

edited

Loading