Update MDL code generator to support MDL 1.7 #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed the sheen implementation to match OSL as close as possible - completed the mix, add, and multiply functions for BSDFs, EDFs, and VDFs - add MDL implementation for mix of surfaceshader, volumeshader, and displacementshader - fixed empty resource paths that showed MaterialX fileprefixes - handled relative resources, but encourage to use `flattenFilenames` on the document before generating MDL in order to have full application control on resource paths
|
@krohmerNV It looks like the EasyCLA system is asking for additional authorization for your CLA, so you may need to click on one of the links above to resolve it. Usually the Linux Foundation is very responsive if you need to file a support ticket. |
The check passed for other PR. This one is still marked as failed. |
|
/easycla |
jstone-lucasfilm
approved these changes
Mar 10, 2023
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
…on#1273) - changed the sheen implementation to match OSL as close as possible - completed the mix, add, and multiply functions for BSDFs, EDFs, and VDFs - add MDL implementation for mix of surfaceshader, volumeshader, and displacementshader - fixed empty resource paths that showed MaterialX fileprefixes - handled relative resources, but encourage to use `flattenFilenames` on the document before generating MDL in order to have full application control on resource paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flattenFilenameson the document before generating MDL in order to have full application control on resource paths