Add drag & drop loading to Web Viewer #1482
Conversation
|
Hi @hybridherbst , |
jstone-lucasfilm
changed the title
|
Hi @kwokcb, there's no changes needed to make paths work, files and references that work locally should also work here. Complexity of drag-drop as implemented here loading just comes from the fact that there are multiple different web APIs and they work slightly different. There may be more efficient ways of doing this (e.g. implementing a custom manager that is able to resolve paths on-the-fly instead of loading all at once) but I think this is a good start. Some examples:
|
|
Thanks for the explanation. I'll admit I'm no |
|
Thanks for the clear explanation. I'll take a closer look at the code for review.
Thanks. |
| import * as THREE from 'three'; | ||
| import * as fflate from 'three/examples/jsm/libs/fflate.module.js'; | ||
|
|
||
| const debugFileHandling = false; |
There was a problem hiding this comment.
Just a general comment, can you add some function header comments for this new file.
You can follow the convention user for the other files.
| { | ||
| const allEntries = []; | ||
|
|
||
| let haveGetAsEntry = false; |
There was a problem hiding this comment.
Maybe move this to the top along with the other debug flag?
|
|
||
| async function handleFilesystemEntries(entries) { | ||
| const allFiles = []; | ||
| const fileIgnoreList = [ |
There was a problem hiding this comment.
Makes sense to not include these, but curious as to why these specific files are specified ?
| // put all files in three' Cache | ||
| for (const fileEntry of allFiles) { | ||
|
|
||
| const allowedFileTypes = [ |
There was a problem hiding this comment.
Curious why only these file types ? Is this all the three.js loader can handle?
Shouldn't this just try and load and catch if it fails.
Also should the extension check be case insensitive?
| dirReader.readEntries( | ||
| async (results) => { | ||
| if (results.length) { | ||
| // entries = entries.concat(results); |
There was a problem hiding this comment.
Nitpick: Should this line be removed?
There was a problem hiding this comment.
This is a valuable enough feature that I'd like to take this in stages, first merging the initial proposal from @hybridherbst, and then iterating on this feature to resolve the issues that @kwokcb brings up.
Great work, and thanks for this contribution!
jstone-lucasfilm
merged commit 00417d7
into
AcademySoftwareFoundation:main
This PR implements drag-drop file loading for - .mtlx files - .mtlx files + textures or folders with textures - folders that contain at least one single .mtlx and textures - .zip files containing the above Currently, only the first found .mtlx file from any of the above will be loaded; future improvements could include - showing a list of dropped .mtlx files to choose from - hot reload when a .mtlx file on disk or a referenced texture changes again - this would turn the web viewer into a pretty nice MaterialX hand editor without having any kind of MaterialX software installed.
This PR implements drag-drop file loading for
Currently, only the first found .mtlx file from any of the above will be loaded; future improvements could include