Update overlay node logic to match reference #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the overlay node to match the overlay operation
in the Adobe PDF spec.
Overlay(cb, cs) = { 2 * cs * cb [if cb <= 0.5]
1 - 2 * (1 - cs) * (1 - cb) [if cb > 0.5]
(cb = B, cs = F in MaterialX specification notation)
It also changes the implementation to graph based instead of
code snippets.
This is done to make the test cover more interesting input
|
Before the fix: |
|
After the fix: |
kwokcb
approved these changes
Sep 22, 2023
|
Great work, @rasmusbonnedal, and I really like the decision to implement this node as a language-independent graph. I don't see any issues that concern me in this change, though I'd like to run this through local tests before merging. |
jstone-lucasfilm
approved these changes
Oct 19, 2023
jstone-lucasfilm
changed the title
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit 78d2762
into
AcademySoftwareFoundation:main
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the overlay node to match the overlay operation in the Adobe PDF spec.
(cb = B, cs = F in MaterialX specification notation)
It also changes the implementation to graph based instead of code snippets.