Improve OSL generation of filename inputs #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasharrysson
commented
Oct 2, 2023
| // Add shader input metadata. | ||
| // | ||
|
|
||
| auto widgetMetadataIt = UI_WIDGET_METADATA.find(input->getType()); |
There was a problem hiding this comment.
Metadata generation was moved out to a separate method, see below.
kwokcb
reviewed
Oct 2, 2023
jstone-lucasfilm
approved these changes
Oct 9, 2023
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit c7f01d8
into
AcademySoftwareFoundation:main
31 checks passed
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
…1547) This change list modifies the generation of public filename parameters from being a textureresource struct, to being two separate string parameters for filename and colorspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change list modifies the generation of public filename parameters from being a
textureresourcestruct, to being two separate string parameters for filename and colorspace.This is to solve the issue discussed in #1463.