Stop Graph Editor from creating imgui.ini file #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osing Graph Editor
iukpo-lucasfilm
force-pushed
the
Issue_1471
branch
from
c82d458
to
7b7055d
Compare
There was a problem hiding this comment.
This looks good to me, thanks @iukpo-lucasfilm!
Although we may want to revisit the notion of configuration INI files in future iterations, I would recommend that we remove the getConfigPath helper function from Main.cpp as part of your change, since it was added specifically for the graph editor INI use case.
The function will always be available in the GitHub history of the MaterialX project, and we can bring it back if configuration INI files become valuable in the future.
|
@jstone-lucasfilm Thank you! I will remove |
jstone-lucasfilm
approved these changes
Oct 14, 2023
jstone-lucasfilm
merged commit 7446251
into
AcademySoftwareFoundation:main
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to stop creation of imgui.ini after saving material after saving then closing Graph Editor (#1471)