Add logical operator node definitions #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt to add logical operators
jstone-lucasfilm
approved these changes
Jun 22, 2024
There was a problem hiding this comment.
This looks like an excellent contribution, @ld-kerley! I'm CC'ing @dbsmythe to make sure the functionality and documentation meets his standards.
jstone-lucasfilm
merged commit 723cebd
into
AcademySoftwareFoundation:main
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When experimenting with some of the
<convert>nodes I found I really wanted a logcical<not>to implementND_convert_integer_booleanas a nodegraph using<ifequal>.We actually have these logical operators in the RealityKit MaterialX nodes already (recently shared publicly at WWDC 2024), so I thought it might be useful to propose we add them to the standard library.