Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LamaSurface Node #1901

Merged
merged 5 commits into from
Jun 25, 2024

Conversation

mkuo-lucasfilm
Copy link
Contributor

@mkuo-lucasfilm mkuo-lucasfilm commented Jun 24, 2024

Adding initial support for LamaSurface node (pixar renderman definition: https://rmanwiki.pixar.com/display/REN26/LamaSurface)

  • LamaSurface has two inputs of BSDF type and one input of float type, and returns a surfacematerial
  • LamaSurface node example is commented out, as there's an issue with the shader generation process, which doesn't yet support the notion of a custom node that returns a surfacematerial

Commenting out LamaSurface node example, as there is not yet support of a custom node that returns a surfacematerial
Connecting presence input to LamaSurface
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @mkuo-lucasfilm!

@jstone-lucasfilm jstone-lucasfilm merged commit 66ac446 into AcademySoftwareFoundation:main Jun 25, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants