Adding support to ignore user specified HTTP headers when searching route handlers #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed build caused by first pull request is due to an brittle test which could fail if the version of 'superagent' changes. The updated pull request contains a fix to the brittle test. |
|
Looks good, merging Thank you for updating README and tests 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to add the ability for Drakov to ignore user specified list of HTTP headers when it searches route handlers.
This feature could be useful if user has to put some headers in API blueprints (for example, for the sake of doing contract tests with Dredd), but don't want to strictly match these headers when Drakov is used as a mock server.