Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"To" should be considered a bogus header. #36

Merged
merged 1 commit into from
Aug 23, 2013
Merged

"To" should be considered a bogus header. #36

merged 1 commit into from
Aug 23, 2013

Conversation

jpmckinney
Copy link

No description provided.

@jpmckinney
Copy link
Author

message-id is another candidate bogus header, but clearly we wouldn't want a "To" header to conflict with the "To" field in the JSON.

@temochka
Copy link
Contributor

temochka commented Aug 8, 2013

Hi,

Thanks! I think we’ll need to add unit tests for that. I’ll make sure to fit it into my next iteration. Also, we allow users to send their own message-id headers, so that header should not be considered bogus.

@jpmckinney
Copy link
Author

Cool. I'm wondering why some of the others are bogus then - what's wrong with:

  • date
  • sender
  • content-type
  • return-path
  • x-pm-rcpt

@temochka
Copy link
Contributor

temochka commented Aug 8, 2013

Good question. I’ll check on that with the API developers to make sure the list is still relevant. Will keep you posted.

@jpmckinney
Copy link
Author

Well, trying to send date or content-type headers returns a 4XX error, with messages like Header 'Date' not allowed. This isn't documented anywhere in Postmark's docs, though.

The "bogus" headers return-path, sender and x-pm-rcpt don't raise any errors from the API if they are included in the request, so they should probably not be "bogus".

temochka added a commit that referenced this pull request Aug 23, 2013
Add "To" to the list of bogus headers.
@temochka temochka merged commit fb750ff into ActiveCampaign:master Aug 23, 2013
@temochka
Copy link
Contributor

I confirmed with the API developers that using other bogus headers may cause certain features of Postmark not to work properly. So I only added To header to the list. Also wrote a simple unit test for this case. Thank you for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants