Skip to content

Commit

Permalink
Merge pull request #30 from ro0gr/avoid-plain-strings-in-definitions
Browse files Browse the repository at this point in the history
avoid "ember-cli-page-object.string-properties-on-definitio" deprecation
  • Loading branch information
mixonic authored Feb 6, 2021
2 parents 6d52831 + 9795e12 commit c968b0b
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions tests/acceptance/simple-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ import { findElement } from 'ember-classy-page-object/extend';
const ToggleButtonPage = PageObject.extend({
toggle: clickable('[data-test-toggle-button]'),

activeClass: 'is-active',
get activeClass() {
return 'is-active';
},

get isActive() {
return findElement(this, '[data-test-toggle-button]').classList.contains(this.activeClass);
Expand All @@ -23,11 +25,13 @@ const DoubleTogglePage = PageObject.extend({

secondToggle: ToggleButtonPage.extend({
scope: '[data-test-second-toggle]',
activeClass: 'is-activated'

get activeClass() {
return 'is-activated';
},
})
});


module('Acceptance | simple', async function(hooks) {
setupApplicationTest(hooks);

Expand Down

0 comments on commit c968b0b

Please sign in to comment.