Testing with ember-cli-page-object v2.0.0-beta.3 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kpfefferle
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
I'd suggest that we merge this to master and release it as an 0.8.0-beta for the ember-table 4.0-beta branch to use? Then when ember-cli-page-object releases a 2.0 stable, we can upgrade to that, release an 0.8 stable here, and then leverage that in the new version of ember-table?
It looks like @mixonic and @twokul have NPM publish permissions for this addon, so hopefully one of them can review/merge this and get a release cut?
twokul
approved these changes
Feb 23, 2022
.github/workflows/ci.yml
Outdated
| @@ -20,7 +20,7 @@ jobs: | |||
| - name: Node Modules Cache | |||
| uses: actions/cache@v2 | |||
| with: | |||
| path: '**/node_modules' | |||
| path: "**/node_modules" | |||
There was a problem hiding this comment.
It seems we use single quotes in this file. Why the change?
|
Going to publish beta today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended our efforts to get
ember-tablecompatible with Ember v4.Changes include:
v2.0.0-beta3branch ofember-cli-page-objecthttps://github.com/san650/ember-cli-page-object/releasesuseNativeEventsPerhaps we could release a beta version of this addon while we wait for a release version of v2 of
ember-cli-page-object