Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.nytimes.com #135303

Closed
adguard-bot opened this issue Nov 20, 2022 · 39 comments
Closed

www.nytimes.com #135303

adguard-bot opened this issue Nov 20, 2022 · 39 comments

Comments

@adguard-bot
Copy link

Issue URL (Social Widget)

https://www.nytimes.com/2022/10/23/arts/television/house-of-the-dragon-showrunner-ryan-condal.html?searchResultPosition=3

Comment

Username: @rakleed

Screenshots

Screenshot 1

Screenshot 1

System configuration

Information value
AdGuard product: AdGuard for Mac v2.9.0.1206+release
Browser: Chrome
Stealth mode options: Hide your search queries,
Remove X-Client-Data header from HTTP requests,
Strip URLs from tracking parameters,
Disable cache for third-party requests,
Hide your Referrer from third-parties (),
Hide your User-Agent ()
DNS filtering: server: https://dns.cloudflare.com/dns-query
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard Tracking Protection,
AdGuard URL Tracking

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances

Language-specific:
AdGuard Russian
Custom filters: https://gitlab.com/magnolia1234/bypass-paywalls-clean-filters/-/raw/main/bpc-paywall-filter.txt
Userscripts: IMDb+Tomatoes+(url:+https://greasyfork.org/scripts/15222-imdb-tomatoes/code/IMDb%20Tomatoes.user.js),
AdGuard+Extra+(url:+https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.user.js)
Referrer: https://www.nytimes.com/search?query=house+of+dragon
@adguard-bot
Copy link
Author

Issue URL (Social Widget)

https://www.nytimes.com/2022/11/19/technology/trump-twitter-musk.html

Comment

Username: @rakleed

Share and Read app

Screenshots

Screenshot 1

Screenshot 1

System configuration

Information value
AdGuard product: AdGuard/AdGuard Pro for iOS v4.4.4
Browser: Safari
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances

Language-specific:
AdGuard Russian

@adguard-bot
Copy link
Author

Issue URL (Incorrect Blocking)

https://www.nytimes.com/2022/11/19/nyregion/buffalo-ny-snowstorm-blizzard.html

Comment

Username: @tempissue

After scroll for a moment, the black overlay appears. I wonder if it’s something in Annoyances blocking an element, but not the overlay.

Screenshots

Screenshot 1

Screenshot 1

Screenshot 2

Screenshot 2

System configuration

Information value
AdGuard product: AdGuard/AdGuard Pro for iOS v4.4.4
Browser: Safari
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard Tracking Protection,
Fanboy's Anti-Facebook List

Annoyances:
AdGuard Annoyances

@jellizaveta
Copy link
Contributor

#135303 (comment) Unfortunately, I have not been able to reproduce this issue. Please try clearing the browser cache and checking the page again

@rakleed
Copy link
Contributor

rakleed commented Nov 24, 2022

@jellizaveta на десктопе есть остатки от кнопки поделиться из-за li с классом css-1xlo06v.

Скриншот

Screenshot 2022-11-24 at 23 12 22@2x

@adguard-bot adguard-bot reopened this Nov 25, 2022
@adguard-bot
Copy link
Author

Issue URL (Social Widget)

https://www.nytimes.com/2022/10/23/arts/television/house-of-the-dragon-showrunner-ryan-condal.html?searchResultPosition=3

Comment

Username: @rakleed

#135303 (comment)

Screenshots

Screenshot 1

Screenshot 1

System configuration

Information value
AdGuard product: AdGuard for Mac v2.9.1.1217+release
Browser: Chrome
Stealth mode options: Hide your search queries,
Remove X-Client-Data header from HTTP requests,
Strip URLs from tracking parameters,
Disable cache for third-party requests,
Hide your Referrer from third-parties (),
Hide your User-Agent ()
DNS filtering: server: https://dns.cloudflare.com/dns-query
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard Tracking Protection,
AdGuard URL Tracking

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances

Language-specific:
AdGuard Russian
Custom filters: https://gitlab.com/magnolia1234/bypass-paywalls-clean-filters/-/raw/main/bpc-paywall-filter.txt
Userscripts: IMDb+Tomatoes+(url:+https://greasyfork.org/scripts/15222-imdb-tomatoes/code/IMDb%20Tomatoes.user.js),
AdGuard+Extra+(url:+https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.user.js)

@github-actions github-actions bot removed the A: In progress Work on the issue is in progress label Nov 25, 2022
@adguard-bot
Copy link
Author

Issue URL (Annoyance)

https://www.nytimes.com/2022/11/27/upshot/road-deaths-pedestrians-cyclists.html

Comment

I can block the pop up with the element picker, but there’s no way to choose the black overlay without also hiding the content. If only the pop up is blocked, then scroll is disabled.

Screenshots

Screenshot 1

Screenshot 1

Screenshot 2

Screenshot 2

System configuration

Information value
AdGuard product: AdGuard/AdGuard Pro for iOS v4.4.4
Browser: Safari
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard Tracking Protection

@Alex-302 Alex-302 added the A: In progress Work on the issue is in progress label Nov 28, 2022
@Alex-302
Copy link
Member

@rakleed #135303 (comment)
Ну это уже перебор.

@rakleed
Copy link
Contributor

rakleed commented Nov 28, 2022

@Alex-302 почему? Можно же сделать такое правило, и всё будет корректно блокироваться:

nytimes.com#?#li:has(> div > div > button[aria-label*="sharing"])

@Alex-302
Copy link
Member

I can block the pop up with the element picker, but there’s no way to choose the black overlay without also hiding the content. If only the pop up is blocked, then scroll is disabled.

Can't reproduce(checked few articles)

@Alex-302
Copy link
Member

Alex-302 commented Nov 28, 2022

@rakleed Потому что это уже нездоровая ситуация - сидеть с микроскопом и высматривать пиксели.

@adguard-bot
Copy link
Author

Issue URL (Incorrect Blocking)

https://www.nytimes.com/interactive/2022/11/29/sports/world-cup/iran-usa-world-cup-goal-pulisic.html

Comment

Images should update as I scroll the article, but with AdGuard enabled the images do not update.

Screenshots

Screenshot 1

Screenshot 1

Screenshot 2

Screenshot 2

System configuration

Information value
AdGuard product: AdGuard Browser extension v4.1.46
Browser: EdgeChromium
Stealth mode: disabled
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection,
EasyPrivacy,
Legitimate URL Shortener,
Fanboy's Enhanced Tracking List,
Peter Lowe's Blocklist

Annoyances:
AdGuard Annoyances,
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Mobile App Banners,
AdGuard Other Annoyances,
Adblock Warning Removal List,
Web Annoyances Ultralist,
I don't care about cookies,
EasyList Cookie List,
Dandelion Sprout's Annoyances List

Security:
Online Malicious URL Blocklist,
NoCoin Filter List

Language-specific:
AdGuard Russian,
AdGuard Chinese,
EasyList China,
ADgk Mobile China list

@adguard-bot adguard-bot reopened this Nov 30, 2022
@github-actions github-actions bot removed the A: In progress Work on the issue is in progress label Nov 30, 2022
@adguard-bot
Copy link
Author

Issue URL (Annoyance)

https://www.nytimes.com/2022/12/04/world/middleeast/iran-morality-police.html

Screenshots

Screenshot 1

Screenshot 1

Screenshot 2

Screenshot 2

System configuration

Information value
AdGuard product: AdGuard/AdGuard Pro for iOS v4.4.4
Browser: Safari
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard Tracking Protection

@adguard-bot
Copy link
Author

@mobamoba
Copy link

mobamoba commented Dec 6, 2022

Just to note on my above report: while most of my tabs use Adguard's SSL Cert, I noticed the NY Times is somehow bypassing Adguard's cert and using Digicert instead which may be why the ads are appearing. And just to confirm, no, nytimes is not on any bypass list and in fact the Adguard extension says "Protection is Enabled" and shows the green button is on yet it's using Digicert not Adguard for SSL.

image

@adguard-bot
Copy link
Author

Issue URL (Incorrect Blocking)

https://www.nytimes.com/2022/12/08/world/europe/germany-plot-qanon.html

Comment

Username: @zubrRB

Screenshots

Screenshot 1

Screenshot 1

Screenshot 2

Screenshot 2

System configuration

Information value
AdGuard product: AdGuard for Windows v7.12+nightly+2
Browser: Chrome
AdGuard driver: TDI
Stealth mode options: Hide your search queries,
Send Do-Not-Track header,
Remove X-Client-Data header from HTTP requests,
Strip URLs from tracking parameters,
Self-destructing third-party cookies (1),
Disable cache for third-party requests,
Block WebRTC,
Block Push API,
Block Location API,
Hide your Referrer from third-parties (example.com),
Hide your User-Agent (),
Hide your IP address ()
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances

Language-specific:
AdGuard Russian
Userscripts: https://github.com/Owyn/HandyImage/raw/master/HandyImage.user.js,
https://greasyfork.org/scripts/14085-kinozal-tv-magnet-links/code/kinozaltv%20magnet%20links.user.js,
https://greasyfork.org/scripts/394820-mouseover-popup-image-viewer/code/Mouseover%20Popup%20Image%20Viewer.user.js,
https://download.sf-helper.com/chrome/helper.user.js,
https://userscripts.adtidy.org/beta/adguard-extra/1.0/adguard-extra.user.js,
https://userscripts.adtidy.org/beta/popup-blocker/2.5/popupblocker.user.js

yourduskquibbles added a commit to yourduskquibbles/webannoyances that referenced this issue Dec 9, 2022
@yourduskquibbles
Copy link

Images should update as I scroll the article, but with AdGuard enabled the images do not update.

This caused by Web Annoyances Ultralist. @yourduskquibbles please take a look.

@Alex-302 thx for reporting, should be fixed now

@Alex-302
Copy link
Member

Alex-302 commented Dec 9, 2022

#135303 (comment)

Not reproduced. Please try with AdGuard Annoyances filter.

@Alex-302
Copy link
Member

Alex-302 commented Dec 9, 2022

@mobamoba Cannot reproduce. Did you try restart a browser and AdGuard?
Also you may try nightly build.

@Alex-302 Alex-302 added the A: Waiting for data Waiting for more information from the user label Dec 9, 2022
@mobamoba
Copy link

mobamoba commented Dec 9, 2022

I think it was a sign of a much deeper bug of some kind as at some point I noticed that Adguard had ceased filtering anything in any browser - the filtering log showed nothing no matter what page I loaded and Adguard itself showed no errors. Fully exiting then restarting Adguard did nothing. Starting a completely different browser that hadn't been running did nothing. Adguard was all green and seemed to think it was running perfectly fine (the logs show no errors) yet it was doing absolutely nothing. The only thing that worked was a full system reboot.

@zubrRB
Copy link

zubrRB commented Dec 9, 2022

@Alex-302 а с моим случаем, что?

@Alex-302
Copy link
Member

@zubrRB Всё в порядке. Что у тебя ломает страницу?

@Alex-302
Copy link
Member

@mobamoba Hmm. Next time please write to support@adguard.com and suggest log files. Probably it was caused by some rare bug.

@zubrRB
Copy link

zubrRB commented Dec 12, 2022

@Alex-302 открывается, скроллится, а через несколько секунд что-то скрывает страницу и вместо неё — белый фон.

@AdamWr
Copy link
Member

AdamWr commented Dec 12, 2022

Regarding incorrect blocking - #135303 (comment)
I suppose that it's related to this issue - AdguardTeam/Scriptlets#268
It should be fixed by this rule:

nytimes.com#%#//scriptlet("set-constant", "Navigator.prototype.joinParakeetInterestGroup", "noopFunc")

from AdGuard Tracking Protection filter, but it doesn't work due to mentioned issue.
Adding this rule:

nytimes.com#%#AG_setConstant('Navigator.prototype.joinParakeetInterestGroup', 'noopFunc')

to user rules should fixes it.

It happens with 7.12 nightly only.

@adguard-bot
Copy link
Author

Issue URL (Ads)

https://www.nytimes.com/2022/12/15/health/covid-dead-bodies.html

Comment

The NYTimes has a pop up asking if I want to use their app. On Safari for iOS, this grays out the screen, but is still scrollable. I can make a AdGuard user rule to hide the gray by selecting anywhere. Ever since NYT has implemented this pop up a month ago, it has made it nearly impossible to use with or without ad guard. Can you make a rule to hide this pop up as part of an update or as an option?

Screenshots

Screenshot 1

Screenshot 1

System configuration

Information value
AdGuard product: AdGuard/AdGuard Pro for iOS v4.4.4
Browser: Safari
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads,
EasyList

Privacy:
AdGuard Tracking Protection,
EasyPrivacy,
Fanboy's Enhanced Tracking List,
Peter Lowe's Blocklist

Social Widgets:
AdGuard Social Media,
Fanboy's Social Blocking List

Annoyances:
AdGuard Annoyances,
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Mobile App Banners,
AdGuard Other Annoyances,
AdGuard Widgets,
Adblock Warning Removal List,
Fanboy's Annoyances,
Web Annoyances Ultralist,
I don't care about cookies,
EasyList Cookie List,
Dandelion Sprout's Annoyances List

Security:
NoCoin Filter List

Other:
Filter unblocking search ads and self-promotion,
AdGuard DNS

@Alex-302
Copy link
Member

The NYTimes has a pop up asking if I want to use their app. On Safari for iOS, this grays out the screen, but is still scrollable. I can make a AdGuard user rule to hide the gray by selecting anywhere. Ever since NYT has implemented this pop up a month ago, it has made it nearly impossible to use with or without ad guard. Can you make a rule to hide this pop up as part of an update or as an option?

Cannot reproduce on iPad and Android whith/without AdGuard.
@jellizaveta @Sergey-Lyapin Please take a look.

@tempissue
Copy link

@Alex-302 @jellizaveta @Sergey-Lyapin this was the same issue I had here #135303 (comment)

@zubrRB
Copy link

zubrRB commented Dec 16, 2022

On version 7.12 nightly 4 with the isEmptyObject fix, the background is still white.

@adguard-bot
Copy link
Author

Issue URL (Incorrect Blocking)

https://www.nytimes.com/2022/12/18/world/europe/ukraine-russia-war-winter.html

Screenshots

Screenshot 1

Screenshot 1

Screenshot 2

Screenshot 2

System configuration

Information value
AdGuard product: AdGuard Browser extension v4.1.52
Browser: YaBrowser
Stealth mode options: Hide your search queries,
Send Do-Not-Track header,
Strip URLs from tracking parameters,
Hide your Referrer from third-parties
Filters: Ad Blocking:
AdGuard Base,
EasyList

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection,
EasyPrivacy,
Legitimate URL Shortener,
Peter Lowe's Blocklist,
Fanboy's Anti-Facebook List

Social Widgets:
AdGuard Social Media,
Fanboy's Social Blocking List

Annoyances:
AdGuard Annoyances,
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Other Annoyances,
Adblock Warning Removal List,
Fanboy's Annoyances,
Web Annoyances Ultralist,
I don't care about cookies,
Dandelion Sprout's Annoyances List

Security:
Online Malicious URL Blocklist,
NoCoin Filter List

Language-specific:
AdGuard Russian,
RU AdList: Counters

@Alex-302
Copy link
Member

@zubrRB

On version 7.12 nightly 4 with the isEmptyObject fix, the background is still white.

All goog with this version.

@zubrRB
Copy link

zubrRB commented Dec 19, 2022

@Alex-302 It only opens normally for me if the ZenMate VPN extension is enabled.

@Alex-302
Copy link
Member

Do you see requests in the filtering log, when Zenmate is turned on?

@zubrRB
Copy link

zubrRB commented Dec 19, 2022

Yes!

Screenshot:

-


@Alex-302
Copy link
Member

Do you see this code in HTML when Zenmate is running?

Details

image

@zubrRB
Copy link

zubrRB commented Dec 19, 2022

No!

Screenshot:

-


@zubrRB
Copy link

zubrRB commented Jan 19, 2023

@Alex-302 последняя проблема была с неработающими фильтрацией и юзерскриптами из-за конфликта с антивирусом.

@AdamWr AdamWr mentioned this issue Aug 28, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants