Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google.com #188923

Closed
adguard-bot opened this issue Sep 16, 2024 · 20 comments
Closed

google.com #188923

adguard-bot opened this issue Sep 16, 2024 · 20 comments

Comments

@adguard-bot
Copy link

Issue URL (Annoyance)

https://www.google.it/

Screenshots

Screenshot 1

Screenshot 1

System configuration

Information Value
AdGuard product: AdGuard Browser Extension v4.4.22
System version: Windows 10
Browser: Edge
Tracking protection options: Strip URLs from tracking parameters,
Hide your search queries,
Send Do-Not-Track header,
Block trackers
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection,
EasyPrivacy,
Legitimate URL Shortener

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances

Security:
Phishing URL Blocklist,
Online Malicious URL Blocklist,
Scam Blocklist by DurableNapkin,
uBlock Origin – Badware risks

Language-specific:
EasyList Italy
Custom filters: https://gitlab.com/DandelionSprout/adfilt/-/raw/master/Alternate versions Anti-Malware List/AntiMalwareAdGuard.txt
Browsing Security: enabled
Browsing Security statistics: disabled
@adguard-bot
Copy link
Author

Issue URL (Incorrect Blocking)

https://www.google.co.uk

Comment

После обновление на MacOS Sequoia, перестала работать AdGuard в Safari. Нечего не грузить. Пока не совсем ясно, проблема в версии MacOS или самой AdGuard.
Username: @abarotoff

Screenshots

Screenshot 1

Screenshot 1

Screenshot 1 with AdGuard disabled

Screenshot 1

System configuration

Information Value
AdGuard product: AdGuard for Mac v2.15.1.1731 release
System version: MacOS Sequoia
Browser: Safari
License type: paid
Tracking protection options: Hide your Referrer from third-parties,
Hide your User-Agent
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base
Browsing Security: enabled
Browsing Security statistics: enabled
Userscripts: disabled
Userstyles: disabled

@github-actions github-actions bot removed the A: In progress Work on the issue is in progress label Sep 17, 2024
@jellizaveta jellizaveta added the A: In progress Work on the issue is in progress label Sep 18, 2024
@jellizaveta
Copy link
Contributor

@abarotoff Здравствуйте, да это уже известная проблема, в качестве временного решения вы можете попробовать отключить iCloud Private Relay должно помочь.
Следить за ответом разработчиков можно тут: AdguardTeam/CoreLibs#1914

@jellizaveta jellizaveta closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2024
@adguard-bot
Copy link
Author

Issue URL (Ads)

https://www.google.com/search?q=%E4%BA%91%E6%9C%8D%E5%8A%A1&ie=UTF-8
Username: @TullyMonster

Screenshots

Screenshot 1

Screenshot 1

System configuration

Information Value
AdGuard product: AdGuard for Android v4.6.2
System version: Android 13
Browser: Chrome
License type: paid
AdGuard mode: proxy
HTTPS filtering: enabled
Proxy mode: auto
Android system root: true
Tracking protection options: Hide your search queries,
Send Do-Not-Track header,
Hide your Referrer from third-parties,
Hide your User-Agent,
Remove X-Client-Data header from HTTP requests,
Self-destructing third-party cookies (180),
Self-destructing first-party cookies (4320)
DNS filtering: server: https://d.adguard-dns.com/dns-query/xxxxxxx
filters: https://filters.adtidy.org/android/filters/15_optimized.txt
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads,
EasyList

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection,
EasyPrivacy,
Legitimate URL Shortener

Social Widgets:
AdGuard Social Media,
Fanboy's Social Blocking List

Annoyances:
AdGuard Annoyances,
AdGuard Popups,
AdGuard Other Annoyances,
AdGuard Mobile App Banners,
AdGuard Widgets,
AdGuard Cookie Notices,
EasyList Cookie List

Security:
Phishing URL Blocklist,
Online Malicious URL Blocklist

Other:
AdGuard DNS,
Filter unblocking search ads and self-promotion

Language-specific:
AdGuard Chinese
Custom filters: https://cdn.jsdelivr.net/gh/uniartisan/adblock_list/adblock_lite.txt
Browsing Security: enabled
Browsing Security statistics: disabled
Userscripts: https://userscripts.adtidy.org/release/disable-amp/1.0/disable-amp.meta.js
https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.meta.js

@adguard-bot
Copy link
Author

Issue URL (Annoyance)

http://www.google.com

Comment

No more trend results in and below searchbar with these filters (for both desktop and mobile layouts):

google.##div[jscontroller="OPwjEf"]
google.
##div.OBMEnb:has(> .ynRric)
google.*##div.ftihzf:has(> .ynRric)
Username: @0xrxL

Screenshots

Screenshot 1

Screenshot 1

Screenshot 2

Screenshot 2

System configuration

Information Value
AdGuard product: AdGuard for Android v4.7 Nightly 24
System version: Android 14
Browser: Samsung Browser
AdGuard mode: VPN
HTTPS filtering: enabled
Tracking protection options: Send Do-Not-Track header,
Hide your Referrer from third-parties,
Hide your User-Agent,
Remove X-Client-Data header from HTTP requests,
Self-destructing third-party cookies (180),
Self-destructing first-party cookies (4320)
DNS filtering: server: https://dns.google/dns-query
filters: https://filters.adtidy.org/android/filters/15_optimized.txt
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Mobile App Banners,
AdGuard Other Annoyances,
AdGuard Widgets

Security:
Phishing URL Blocklist,
Scam Blocklist by DurableNapkin,
uBlock Origin – Badware risks,
Online Malicious URL Blocklist

Other:
AdGuard DNS,
AdGuard Experimental

Language-specific:
EasyList Italy
Browsing Security: enabled
Browsing Security statistics: disabled
Userscripts: https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.meta.js
https://userscripts.adtidy.org/release/disable-amp/1.0/disable-amp.meta.js
PuryStream_Redirector_v0.03(local)

@adguard-bot
Copy link
Author

Issue URL (Annoyance)

https://www.google.com/search?q=test

Comment

Google search results links are filled with redirects and garbages with filters above all enabled.

uBlock origin can strip all the garbos and get the original clean url with ublock privacy filter https://ublockorigin.github.io/uAssetsCDN/filters/privacy.min.txt enabled

However, addding the same filter to AdGuard does not remove all the tracking parts at all.

Is it possible for AdGuard to make link url on Google search result page clean?
Username: @billkewl

Screenshots

Screenshot 1

Screenshot 1

System configuration

Information Value
AdGuard product: AdGuard for Mac v2.15.1.1731 release
Browser: Firefox
License type: paid
Tracking protection options: Block WebRTC,
Block Push API,
Block Location API,
Block Java,
Strip URLs from tracking parameters,
Hide your search queries,
Send Do-Not-Track header,
Hide your Referrer from third-parties,
Hide your User-Agent,
Remove X-Client-Data header from HTTP requests,
Protect against DPI,
Disable cache for third-party requests,
Block third-party Authorization header,
Block trackers
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard Tracking Protection,
AdGuard URL Tracking,
EasyPrivacy,
Legitimate URL Shortener

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances,
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Other Annoyances,
AdGuard Widgets,
Adblock Warning Removal List
Custom filters: https://cdn.jsdelivr.net/gh/uBlockOrigin/uAssetsCDN@main/filters/privacy.min.txt
Browsing Security: enabled
Browsing Security statistics: disabled
Userscripts: AdGuard Extra (url: https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.user.js)
Userstyles: disabled

@adguard-bot
Copy link
Author

Issue URL (Annoyance)

https://www.google.com/about/careers/applications/cloud

Screenshots

Screenshot 1

Screenshot 1

System configuration

Information Value
AdGuard product: AdGuard Browser Extension v5.0.91
Browser: Chrome
Tracking protection: disabled
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard Tracking Protection,
AdGuard URL Tracking

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Mobile App Banners,
AdGuard Other Annoyances,
AdGuard Widgets

Security:
Online Malicious URL Blocklist,
Phishing URL Blocklist,
Scam Blocklist by DurableNapkin,
uBlock Origin – Badware risks
Browsing Security: disabled
Browsing Security statistics: disabled

@Alex-302 Alex-302 added the A: In progress Work on the issue is in progress label Sep 23, 2024
@Alex-302
Copy link
Member

@TullyMonster Please disable Filter unblocking search ads and self-promotion.

Alex-302 added a commit that referenced this issue Sep 23, 2024
@Alex-302
Copy link
Member

@0xrxL Thanks.

@Alex-302
Copy link
Member

@billkewl It does not support at the moment. You may create a feature request about urlskip here
https://github.com/AdguardTeam/tsurlfilter/issues/
Related to gorhill/uBlock@266ec48

@billkewl
Copy link

@billkewl It does not support at the moment. You may create a feature request about urlskip here https://github.com/AdguardTeam/tsurlfilter/issues/ Related to gorhill/uBlock@266ec48

Oddly I can only find ||youtube.com/redirect?$urlskip=?q in ublock privacy filter list and in ubo release version I got "invalid filter. unsupported filter option" error

It seems it's already requested before but isn't tsurlfilter for AdGuard browser extensions? Is it CoreLibs for macOS, Windows and Android Apps?

@Alex-302
Copy link
Member

It seems it's already requested before

that request is for our VSCode plugin, not for ad blockers.

@adguard-bot
Copy link
Author

Issue URL (Incorrect Blocking)

https://www.google.com/maps

Comment

When using the PC version of Google Maps,
After planning the navigation, the blue navigation route cannot be dragged to the desired path.
Later I found out it was an ad-blocking package, such as AdGuard.
Try closing (pausing) AdGuard and pressing F5 to refresh the page.
Google Map The functionality returned to normal immediately.

Please help check to see where the problem is, thank you.
Username: @KevinYu0504

Screenshots

Screenshot 1

Screenshot 1

Screenshot 1 with AdGuard disabled

Screenshot 1

System configuration

Information Value
AdGuard product: AdGuard Browser Extension v5.0.91
System version: Windows 10
Browser: Chrome
Tracking protection: disabled
Filters: Ad Blocking:
AdGuard Base

Annoyances:
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Mobile App Banners,
AdGuard Other Annoyances,
AdGuard Widgets

Security:
Online Malicious URL Blocklist

Other:
Filter unblocking search ads and self-promotion

Language-specific:AdGuard Russian,
AdGuard German,
AdGuard Japanese,
AdGuard Dutch,
AdGuard Spanish/Portuguese,
AdGuard Turkish,
AdGuard French,
Official Polish filters for AdBlock, uBlock Origin & AdGuard,
AdGuard Chinese,
EasyList Czech and Slovak,
EasyList Italy,
EasyList Lithuania,
Liste AR,
AdBlockID,
EasyList Thailand,
Hungarian,
ABPVN List,
List-KR,
Polish Anti Adblock Filters,
Dandelion Sprout's Nordic Filters
Browsing Security: disabled
Browsing Security statistics: disabled
Other extensions used: Malwarebytes Browser Guard

@billkewl
Copy link

It seems it's already requested before

that request is for our VSCode plugin, not for ad blockers.

Should I request in CoreLibs for desktop and mobile apps support?

@Alex-302
Copy link
Member

@billkewl Yes, Corelibs is ok, and mention in the comment this repo https://github.com/AdguardTeam/tsurlfilter New syntax should be added in both.

@Alex-302 Alex-302 changed the title google.com google.com Sep 24, 2024
@Alex-302
Copy link
Member

@KevinYu0504 Hi. Cannot reproduce with your settings. Which filters group causes it?

@Alex-302 Alex-302 added the A: Waiting for data Waiting for more information from the user label Sep 24, 2024
@KevinYu0504
Copy link

@Alex-302 Hi , sorry I don't have the answer .

I don't know which filters is responsible.

A strange thing I noticed is that when Adguard was turned on,
no matter how many times I refresh (F5) the Google Maps page,
The drag function is faule.

However, after disabling Adguard, the dragging function will still occasionally fail.
But usually after re flash the page (F5), usually can resumes normal.

I'm starting to wonder if it's a Google Maps bug rather than Adguard?

Sorry I'm not a pro about this , can't provide any more details.

Anyway , thanks for help and reply .

@Alex-302
Copy link
Member

@KevinYu0504 You may try to check when groups are disabled. Then enable one by one with checking.

image

@billkewl
Copy link

billkewl commented Sep 24, 2024

@Alex-302 I have created the issue here
However, I noticed that $urlskip is supported after New in 1.60.0. and I'm on uBO 1.59.0
Are you sure it's this modifier that remove the tracking part? not href-sanitizer?

It seems to me that it's href-sanitizer rule

!#if !env_mobile
www.google.*###main a[href][data-sb^="/url?"]:remove-attr(data-sb)
!#else
www.google.*##+js(href-sanitizer, #main a[href^="/url?q=http"], ?q)
www.google.*###main a[href][ping^="/url?"]:remove-attr(ping)

that remove the trash.
However AdGuard can not parse the rules but that's a different issue.

Isn't href-sanitizer already supported in scriptlet? But theres no similar rules in privacy related lists of AdGuard that users have to rewrite them in AdGuard syntax.

@Alex-302
Copy link
Member

@billkewl With urlskip browser will jump to destination. No need to change HTML.

@billkewl
Copy link

billkewl commented Sep 30, 2024

@Alex-302 $urlskip may be able to jump but it doesn't solve copy link issue. links we get from right click copy are still nasty tracking urls. I use Skip Redirect as a replacement for $urlskip currently

BTW. This randomly stops working in AdGuard desktop App whereas it works consistently as in uBO. I still get nasty links at times.

!#if !env_mobile
www.google.*###main a[href][data-sb^="/url?"]:remove-attr(data-sb)
!#else
www.google.*##+js(href-sanitizer, #main a[href^="/url?q=http"], ?q)
www.google.*###main a[href][ping^="/url?"]:remove-attr(ping)

my guess is that scriptlet is too slow to apply the rules.
Is it possible to enhance the function of browser assistant extensions for AdG desktop app so that rules that take time to finish (HTTPS filtering? scriptlet?) can run within browser (faster) just like uBO?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants