add testcases with string value

AdguardTeam · Jan 12, 2023 · 39f1c2d · 39f1c2d
1 parent bb1960e
commit 39f1c2d
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/src/helpers/string-utils.js b/src/helpers/string-utils.js
@@ -379,7 +379,7 @@ export function generateRandomResponse(customResponseText) {
  *
  * @param {string} value arbitrary string
  * @returns {any} converted value
- * @throws on unexpected input
+ * @throws an error on unexpected input
  */
 export function inferValue(value) {
     if (value === 'undefined') {

diff --git a/tests/scriptlets/trusted-set-constant.test.js b/tests/scriptlets/trusted-set-constant.test.js
@@ -68,11 +68,31 @@ if (!isSupported) {
         clearGlobalProps(nullProp1);
 
         // setting constant to string
-        const stringProp1 = 'stringProp';
+        const stringProp1 = 'stringProp1';
         runScriptletFromTag(stringProp1, '"123arbitrary string"');
-        assert.strictEqual(window[stringProp1], '123arbitrary string', 'string type value is set');
+        assert.strictEqual(window[stringProp1], '123arbitrary string', 'arbitrary type value is set');
         clearGlobalProps(stringProp1);
 
+        const stringProp2 = 'stringProp2';
+        runScriptletFromTag(stringProp2, '"true"');
+        assert.strictEqual(window[stringProp2], 'true', '"true" is set as string');
+        clearGlobalProps(stringProp2);
+
+        const stringProp3 = 'stringProp3';
+        runScriptletFromTag(stringProp3, '"NaN"');
+        assert.strictEqual(window[stringProp3], 'NaN', '"NaN" is set as string');
+        clearGlobalProps(stringProp3);
+
+        const stringProp4 = 'stringProp4';
+        runScriptletFromTag(stringProp4, '"undefined"');
+        assert.strictEqual(window[stringProp4], 'undefined', '"undefined" is set as string');
+        clearGlobalProps(stringProp4);
+
+        const stringProp5 = 'stringProp5';
+        runScriptletFromTag(stringProp5, '"null"');
+        assert.strictEqual(window[stringProp5], 'null', '"null" is set as string');
+        clearGlobalProps(stringProp5);
+
         // setting constant to NaN
         const nanProp1 = 'nanProp';
         runScriptletFromTag(nanProp1, 'NaN');