refactor and update readme

AdguardTeam · Dec 15, 2022 · dc38b52 · dc38b52
1 parent 35440f5
commit dc38b52
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -161,9 +161,10 @@ And also there is a module at `dist/scriptlets.js` which has been exported to a
 
 ```javascript
 /**
- * Returns scriptlet code
+ * Returns scriptlet code by param
  * @param {Source} source
- * @returns {string}
+ * @returns {string|null} scriptlet code
+ * @throws on unknown scriptlet name
  */
 scriptlets.invoke(source);
 ```

diff --git a/src/scriptlets/index.js b/src/scriptlets/index.js
@@ -29,20 +29,22 @@ import { getScriptletFunction } from '../../tmp/scriptlets-func';
  * Returns scriptlet code by param
  * @param {Source} source
  * @returns {string|null} scriptlet code
+ * @throws on unknown scriptlet name
  */
 function getScriptletCode(source) {
     if (!validator.isValidScriptletName(source.name)) {
         return null;
     }
 
-    const scriptletFunction = getScriptletFunction(source.name)?.toString();
-    if (!scriptletFunction) {
+    const scriptletFunction = getScriptletFunction(source.name);
+    if (typeof scriptletFunction !== 'function') {
         throw new Error(`Error: cannot invoke scriptlet with name: '${source.name}'`);
     }
+    const scriptletFunctionString = scriptletFunction.toString();
 
     const result = source.engine === 'corelibs' || source.engine === 'test'
-        ? wrapInNonameFunc(scriptletFunction)
-        : passSourceAndProps(source, scriptletFunction);
+        ? wrapInNonameFunc(scriptletFunctionString)
+        : passSourceAndProps(source, scriptletFunctionString);
     return result;
 }