#269 Brave Browser Detection #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Problem There is no detection for Brave Browser in this library. # Solution Add `userAgentData` inspection to detect Brave Browser. Note that `userAgentData` can also be used to detect `Chrome` over the legacy `userAgent` string.
|
@MattSenter this is awesome work! Could you check the lint errors and push again? |
|
@AhsanAyaz Updated! Sorry it took so long. |
|
@AhsanAyaz fixed conflicts |
|
@AhsanAyaz I think the workflow might be busted. I'm not seeing a linting or testing issue on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no detection for Brave Browser in this library.
Solution
Add
userAgentDatainspection to detect Brave Browser. Note thatuserAgentDatacan also be used to detectChromeover the legacyuserAgentstring.