More tests, fixes and optimizations #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed: isShadda now always returns a boolean and doesn't use regex fixed: arabicrange() now doesn't throw an error added: more tests enhanced: arabicrange() now memoized (caches the result instead of redundant recalculation) changed: most is* functions are now in a seperate file, however it is more of an implementation details and doesn't affect araby APIs next: reducing the use of regex in araby and not using it at all if possible
assem-ch
added a commit
that referenced
this pull request
Feb 22, 2014
More tests, fixes and optimizations
assem-ch
added a commit
that referenced
this pull request
Oct 12, 2016
More tests, fixes and optimizations Former-commit-id: 090cc10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: isShadda now always returns a boolean and doesn't use regex
fixed: arabicrange() now doesn't throw an error
added: more tests
enhanced: arabicrange() now memoized (caches the result instead of redundant recalculation)
changed: most is* functions are now in a seperate file, however it is more of an implementation details and doesn't affect araby APIs
next: reducing the use of regex in araby and not using it at all if possible