ACS-8770: fix api service bugs and remove workarounds #10212
+411
−391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-web-ua
approved these changes
Sep 13, 2024
mserwicki
reviewed
Sep 13, 2024
lib/core/src/lib/auth/authentication-interceptor/authentication.interceptor.spec.ts
Show resolved
Hide resolved
lib/core/src/lib/auth/authentication-interceptor/authentication.interceptor.ts
Show resolved
Hide resolved
DenysVuika
force-pushed
the
feat/auth-service-cleanup
branch
from
43965a1
to
6630775
Compare
DenysVuika
force-pushed
the
feat/auth-service-cleanup
branch
from
3bd2ed9
to
ed48ef6
Compare
|
swapnil-verma-gl
approved these changes
Sep 19, 2024
dominikiwanekhyland
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
isExcludedErrorListenernever working (add unit tests)AlfrescoApiNoAuthServiceintoAlfrescoApiServiceDebugAppConfigService(used in former demo shell)Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://hyland.atlassian.net/browse/ACS-8770