[MNT-24628] Handle difference between config object and browser storage ticket #10270
+110
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagosalvado10
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
|
Added unit tests. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Following the steps from MNT-24628 we end up having different tickets in the client config object and browser local storage - where the ticket from config object is causing a 401 error. If the ticket from browser storage is used the request is successful.
What is the new behaviour?
The function
AlfrescoApiClient.getAlfTicket(string)is now checking if tickets are different, if so, returns the ticket from browser storage and emits an event to initialize the API client and auth objects with the new ticket.The second time the function is called, the config object will contain the correct ticket (i.e. equals to the storage one) and the request will work.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: