Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ATS-984 Use pre-commit to fix and prevent whitespace issues #540

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

ATS-984 Use pre-commit to fix and prevent whitespace issues #540

wants to merge 15 commits into from

Conversation

mteodori
Copy link
Member

@mteodori mteodori commented Feb 23, 2022 •
edited
Loading

  • Add pre-commit to check json syntax for travis, github actions and dependabot
  • fix mixed-line-ending
  • exclude gimp files
  • end-of-file-fixer
  • add trailing-whitespace
  • fix trailing-whitespace
  • Add check-yaml
  • fix trailing-whitespace
  • add editorconfig and checker

Ref. ATS-984

@pr-triage pr-triage bot added the PR: draft label Feb 23, 2022
@mteodori mteodori changed the title ATS pre commit Use pre-commit to fix and prevent syntax issues Feb 24, 2022
@mteodori mteodori mentioned this pull request Feb 24, 2022
Merged
@mteodori mteodori marked this pull request as ready for review February 24, 2022 11:14
@mteodori mteodori changed the title Use pre-commit to fix and prevent syntax issues ATS-984 Use pre-commit to fix and prevent whitespace issues Feb 24, 2022
tpage-alfresco
tpage-alfresco approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@tpage-alfresco tpage-alfresco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

@killerboot killerboot removed their request for review September 4, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpage-alfresco tpage-alfresco tpage-alfresco approved these changes

@montgolfiere montgolfiere Awaiting requested review from montgolfiere

@alandavis alandavis Awaiting requested review from alandavis

@skopf skopf Awaiting requested review from skopf

@jamalkm jamalkm Awaiting requested review from jamalkm

Assignees
No one assigned
Labels
PR: partially-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mteodori @tpage-alfresco