Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

fix: fixing eslint warning; Obtaining swaps configs by note prefix #122

Merged
merged 7 commits into from
Sep 2, 2022

Conversation

aorumbayev
Copy link
Contributor

Description

Please explain the changes you made here

  • Adding fixes for eslint warnings
  • Relying on note prefix when fetching proxy config transactions

Checklist

Please, make sure to comply with the checklist below before expecting review

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #122 (a4c438d) into main (9660a32) will increase coverage by 0.48%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   44.14%   44.62%   +0.48%     
==========================================
  Files         101      101              
  Lines        2304     2308       +4     
  Branches      208      209       +1     
==========================================
+ Hits         1017     1030      +13     
+ Misses       1262     1253       -9     
  Partials       25       25              
Impacted Files Coverage Δ
src/components/Tables/AssetsTable.tsx 22.72% <ø> (ø)
src/pages/swap/[proxy]/[escrow].page.tsx 49.24% <ø> (ø)
src/utils/api/assets/assetsToRawString.ts 16.66% <ø> (+4.16%) ⬆️
src/utils/ipfsToProxyUrl.ts 50.00% <ø> (ø)
src/utils/api/accounts/getPublicSwapCreators.ts 13.33% <16.66%> (+1.33%) ⬆️
src/utils/api/swaps/loadSwapConfigurations.ts 42.10% <28.57%> (+8.77%) ⬆️
src/common/constants.ts 83.33% <100.00%> (ø)
src/utils/api/swaps/createSaveSwapConfigTxns.ts 100.00% <0.00%> (+71.42%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Deploy preview for algoworld-swapper-staging ready!

✅ Preview
https://algoworld-swapper-staging-86gfbsyqp-algoworldexplorer.vercel.app
https://pr122-188.vercel-action.millionalgos.com

Built with commit a4c438d.
This pull request is being automatically deployed with vercel-action

@aorumbayev aorumbayev merged commit b598568 into main Sep 2, 2022
@aorumbayev aorumbayev deleted the refactor/note-prfix branch September 2, 2022 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant