-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow lock guards to be sent to other threads #240
Conversation
cc @arthurprs |
Cargo expects features to be additive. This means that enabling features must never break code. It must only allow more code. By making the deadlock detection feature disable the |
While that's the expectation, there are lots and lots of examples of mutually exclusive features out there. But that's just my opinion. |
In those cases it is often choosing between two or more backends for a crate. This means that 1. the target executable is likely the one enabling the feature flag and 2. you can't accidentally depend on a feature flag being disabled, as you have to explicitly enable one feature flag to break another one. You can't just have a crate compiling with no feature flags enabled at all and then break when you enable one feature flag. |
A better alternative than simply breaking code when enabling the |
@bjorn3 That sounds like a great idea! |
But only if deadlock detection is not enabled. Fixes #197
227219e
to
cf9635d
Compare
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
But only if deadlock detection is not enabled.
Fixes #197