Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change log level from 4 to 5 for the logic that logs last applied annotation #82

Closed
AmitKumarDas opened this issue Dec 18, 2019 · 1 comment
Closed

Change log level from 4 to 5 for the logic that logs last applied annotation #82

AmitKumarDas opened this issue Dec 18, 2019 · 1 comment
Labels
chore good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AmitKumarDas
Copy link
Owner

Problem Statement: Following block of code should be modified to use log level 5 instead of log level 4. This log seems to be extra debug info & can be treated on same level as hook response received from hook invocations.

https://github.com/AmitKumarDas/metac/blob/master/dynamic/apply/apply.go#L80-L87
@AmitKumarDas AmitKumarDas added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 18, 2019
floriankoch pushed a commit to floriankoch/metac that referenced this issue Apr 14, 2020
chore(loglevel): AmitKumarDas#82 change loglevel to V5
7678e90 
Signed-off-by: Florian Koch <flo@ctrl.wtf>
@floriankoch floriankoch mentioned this issue Apr 14, 2020
Merged
AmitKumarDas pushed a commit that referenced this issue Apr 15, 2020
chore(loglevel): #82 change loglevel to V5 (#132)
e02b606 
Signed-off-by: Florian Koch <flo@ctrl.wtf>
@floriankoch
Copy link
Collaborator

floriankoch commented Apr 18, 2020 •
edited
Loading

Its merged so close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AmitKumarDas @floriankoch