Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github actions / workflow #87

Open
AmitKumarDas opened this issue Jan 5, 2020 · 5 comments
Open

add github actions / workflow #87

AmitKumarDas opened this issue Jan 5, 2020 · 5 comments
Assignees
Labels
ci-cd good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AmitKumarDas
Copy link
Owner

It will be great to add GitHub Actions based CI CD workflow to Metac. Metac has Travis doing all the CI CD stuff as of now. However, an additional CI CD tooling esp. GitHub Actions should be good to have considering its acceptance over the last few months.

@grzesuav
Copy link
Collaborator

So currently basic flow is achieved, we have working release pipeline.

What next ?

  • static analysis ?
  • code coverage ?

@AmitKumarDas
Copy link
Owner Author

Thanks again @grzesuav
Let's add all badges that includes above and more. I hope these should be relatively easy.

@grzesuav
Copy link
Collaborator

For code coverage I notice several solutions :

it basically runs go test --cover and uploads test reult to third party storage, also we can retrieve bagde (and moreover on every PR there will be comments added with information how coverage will change with given PR)

do you have any preference ? I haven't been using any of those so I cannot list any pros/cons

@AmitKumarDas
Copy link
Owner Author

Anything is fine. Can we have a union of make unit-test and make integration as code coverage. Both of them are go test actually.

@AmitKumarDas
Copy link
Owner Author

AmitKumarDas commented Mar 31, 2020

We need to add -cover to relevant make targets in Makefile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants