Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BaseExtractor): add protocols support #1863

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

twlite
Copy link
Collaborator

@twlite twlite commented Oct 31, 2023

Changes

This PR adds support for protocol list, which is declared by the registered extractors. The behavior is similar to lavalink. For example, if you need to make youtube search, you can use ytsearch:QUERY_VALUE, which will be routed to the extractor that supports this protocol. If no extractor is found, discord-player switches back to old behavior.

Default extractors such as:

  • YoutubeExtractor (ytsearch, youtube)
  • SoundcloudExtractor (scsearch, soundcloud)
  • SpotifyExtractor (spsearch, spotify)
  • AppleMusicExtractor (amsearch, applemusic)

support protocols.

Status

  • These changes have been tested and formatted properly.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

@twlite twlite added area:main Related to discord-player area:extractor Extractors related labels Oct 31, 2023
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
discord-player-website ⬜️ Ignored (Inspect) Oct 31, 2023 5:28pm

@twlite twlite merged commit 927e978 into master Oct 31, 2023
4 checks passed
@twlite twlite deleted the query-protocol-management branch October 31, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:extractor Extractors related area:main Related to discord-player
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant