Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

302 calculate #123

Merged
merged 5 commits into from
Jan 22, 2018
Merged

302 calculate #123

merged 5 commits into from
Jan 22, 2018

Conversation

gentee
Copy link
Member

@gentee gentee commented Jan 17, 2018

No description provided.

potehinre
potehinre approved these changes Jan 18, 2018
View reviewed changes
packages/template/calculate.go Outdated
'/': {tkDiv, 2},
}
for off, ch := range input {
if (ch >= '0' && ch <= '9') || ch == '.' {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if unicode.IsDigit(ch) || ch == '.'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@gentee gentee merged commit 914d838 into master Jan 22, 2018
@gentee gentee deleted the 302-calculate branch January 23, 2018 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potehinre potehinre potehinre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gentee @potehinre @c-darwin