Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed processor_id range overflow #10948

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Fixed processor_id range overflow #10948

merged 1 commit into from
Apr 9, 2020

Conversation

daohu527
Copy link
Contributor

@daohu527 daohu527 commented Apr 4, 2020

#10902

  1. Fixed in "SchedulerChoreography::RemoveCRoutine", add a condition pid should less than processor num
  2. Fixed in "SchedulerChoreography::NotifyProcessor", add a condition pid should less than processor num, move the "pid = cr->processor_id();" in the lock block.

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2020

CLA assistant check
All committers have signed the CLA.

@jinghaomiao
Copy link
Contributor

@daohu527 please fix lint error.

@lx18233184051
Copy link
Contributor

build faild log:
[05:34:57] ____(04-07 05:34:57.230) [6,764 / 6,775] Testing //cyber/scheduler:scheduler_choreography_cpplint
[05:34:57] FAIL: (04-07 05:34:57.592) //cyber/scheduler:scheduler_choreography_cpplint (see /home/apollo/.cache/bazel/_bazel_apollo/540135163923dd7d5820f3ee4b306b32/execroot/apollo/bazel-out/local-dbg/testlogs/cyber/scheduler/scheduler_choreography_cpplint/test.log)
[05:34:57] ____(04-07 05:34:57.597) From Testing //cyber/scheduler:scheduler_choreography_cpplint:

@daohu527
Copy link
Contributor Author

daohu527 commented Apr 7, 2020

thx! I am dealing with it.

Copy link
Contributor

@lx18233184051 lx18233184051 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@lfcarol lfcarol merged commit ba79b21 into ApolloAuto:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants