-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds filter by machine name to interface terminals #203
Conversation
👍 |
Maybe a config setting for filtering by the pattern? |
Last commit adds the ability to filter by pattern. |
@Override | ||
public void initGui() | ||
{ | ||
super.initGui(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespace change, especially since this is in the second commit with nothing near it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just favor using whitespaces to group related code together. At least for myself this makes it easier to follow the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just saying that Adds filter by pattern to the interface terminals
is not the right place for it. A small thing, but still.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, the second commit/iteration also contained some code cleanup. Should have added it to the commit message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yueh You can! git commit --amend -m 'new message'
, then git push --force
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I know. 😄
I'm using it frequently to fix typos or add smaller things (like the missed autofocus).
Other than that and possibly configuration for filtering by patterns, 👍 |
I'm currently planning which different types of filtering are useful.
Also considering cards to upgrade it. Like filter by pattern only available when using a Fuzzy Card. |
Adds filter by machine name to interface terminals
First iteration for #129, it supports only filtering by the machine/interface name.
Filtering by the pattern itself should be possible, but would involve parsing every tooltip for every pattern.
This could be a bit heavy on the computational side and would also filter by ingredients, product or whatever else the tooltip contains.