Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds filter by machine name to interface terminals #203

Merged
merged 2 commits into from
Sep 30, 2014

Conversation

yueh
Copy link
Member

@yueh yueh commented Sep 30, 2014

First iteration for #129, it supports only filtering by the machine/interface name.

Filtering by the pattern itself should be possible, but would involve parsing every tooltip for every pattern.
This could be a bit heavy on the computational side and would also filter by ingredients, product or whatever else the tooltip contains.

@PlasmaPower
Copy link

👍

@PlasmaPower
Copy link

Maybe a config setting for filtering by the pattern?

@yueh
Copy link
Member Author

yueh commented Sep 30, 2014

Last commit adds the ability to filter by pattern.
I would highly recommend testing this with some networks contain a large amount of patterns.

@Override
public void initGui()
{
super.initGui();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace change, especially since this is in the second commit with nothing near it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just favor using whitespaces to group related code together. At least for myself this makes it easier to follow the code.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just saying that Adds filter by pattern to the interface terminals is not the right place for it. A small thing, but still.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, the second commit/iteration also contained some code cleanup. Should have added it to the commit message.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yueh You can! git commit --amend -m 'new message', then git push --force.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I know. 😄
I'm using it frequently to fix typos or add smaller things (like the missed autofocus).

@PlasmaPower
Copy link

Other than that and possibly configuration for filtering by patterns, 👍

@yueh
Copy link
Member Author

yueh commented Sep 30, 2014

I'm currently planning which different types of filtering are useful.
Currently considering:

  • Filter by machine/interface name
  • Filter by pattern tooltip (still displaying the interface name to group the results)
    • Only product (if possible?)
    • Only ingredients (if possible?)
  • Some variation (like ignoring machines with no patterns but matching search term)

Also considering cards to upgrade it. Like filter by pattern only available when using a Fuzzy Card.
Or even View Cells.

Cisien added a commit that referenced this pull request Sep 30, 2014
Adds filter by machine name to interface terminals
@Cisien Cisien merged commit da34968 into AppliedEnergistics:rv2 Sep 30, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants