Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split coremod and mod container to different classes #2670

Closed
wants to merge 1 commit into from
Closed

Split coremod and mod container to different classes #2670

wants to merge 1 commit into from

Conversation

Prototik
Copy link

@Prototik Prototik commented Dec 1, 2016

Don't be a jerk part 2.

Inspired by #2482 #2509 #2519 #2621 #2642 #2661. Tried to fix by #2604. Ignored in #2636. All world against me.

Guys, seriously - it's fault of AE, not Sponge, Forge, FML, Santa Claus or someone else. IFMLLoadingPlugin should load minimal amount of classes to work properly. It's probably bad idea to load half of FML in coremod stage. Current sort of AppEngCore breaks separation of concerns rule at least, so if you don't respect me - respect your programming skill and don't ignore it, don't close it with no reason and don't shout "everyone do it wrong, that's work with clean forge so shut up". Be reasonable, please.

This PR don't break anything, but could save your time as you don't need to close 20 more tickets with a title "crash with sponge".

@yueh
Copy link
Member

yueh commented Dec 1, 2016

As already said the goal is to remove the coremod completely, not fix it with a band-aid and forget it until it bites us again.

Should it not be possible, sure splitting it will be the option. But that should be the option of last resort, not the first one which allows us to forget about it again.

@yueh yueh closed this Dec 1, 2016
@Prototik
Copy link
Author

Prototik commented Dec 1, 2016

Oh, that's problem? One momento.

@lucasdidur
Copy link

How long will it take for this problem to be fixed? Days, weeks, months, years?

@ghost
Copy link

ghost commented Dec 1, 2016

it's had only been 9 hours since he last said something. However, that doesn't mean that the team is going to accept his PR, which they have every right choose so. There is a big discussion on another issue somewhere here, but I don't have a link to it and it will tell you everything you need to know.

@humroben
Copy link

humroben commented Dec 6, 2016

I was just looking this up in the issues, and I'm glad to see that this has already been acknowleged. I'm not worried about how long it takes, since letting mod developers work on it in their own time, allows them to make sure that it gets done right.

Keep up the good work

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants