Split coremod and mod container to different classes #2670
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't be a jerk part 2.
Inspired by #2482 #2509 #2519 #2621 #2642 #2661. Tried to fix by #2604. Ignored in #2636.
All world against me.Guys, seriously - it's fault of AE, not Sponge, Forge, FML,
Santa Clausor someone else. IFMLLoadingPlugin should load minimal amount of classes to work properly. It's probably bad idea to load half of FML in coremod stage. Current sort of AppEngCore breaks separation of concerns rule at least, so if you don't respect me - respect your programming skill and don't ignore it, don't close it with no reason and don't shout "everyone do it wrong, that's work with clean forge so shut up". Be reasonable, please.This PR don't break anything, but could save your time as you don't need to close 20 more tickets with a title "crash with sponge".