Make controller size limits configurable #2671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orod-org
reviewed
Dec 1, 2016
| @@ -195,6 +198,10 @@ private AEConfig( final File configFile ) | |||
| this.colorApplicatorBattery = this.get( "battery", "colorApplicator", this.colorApplicatorBattery ).getInt( this.colorApplicatorBattery ); | |||
| this.matterCannonBattery = this.get( "battery", "matterCannon", this.matterCannonBattery ).getInt( this.matterCannonBattery ); | |||
|
|
|||
| this.controllerMaxX = this.get( "controller", "maxX", this.controllerMaxX ).getInt( this.controllerMaxX ); | |||
There was a problem hiding this comment.
Define a constant instead of duplicating this literal "controller" 3 times. 
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
XFactHD
suggested changes
Dec 1, 2016
|
@XFactHD that's problem of people how to load chunks properly. With current limit in 7 blocks it's also possible to build controller in different chunks. Despite this config properties could be used to decrease max size too. |
|
Okay, then I'll create mod that fix this behaviour instead of patching every version of ae... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.