Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Bug: #0880 - ME Chest can't be protected by ME Security Terminal. #6

Merged
merged 2 commits into from
Sep 27, 2014
Merged

Fixed Bug: #0880 - ME Chest can't be protected by ME Security Terminal. #6

merged 2 commits into from
Sep 27, 2014

Conversation

thepaperpilot
Copy link
Contributor

No description provided.

@AlgorithmX2
Copy link
Contributor

Previously was #3

@AlgorithmX2 AlgorithmX2 added the bug Self explanatory? label Sep 26, 2014
@thepaperpilot
Copy link
Contributor Author

After discussion with Algo, I "fixed" this in a different way.
Before this second commit, you needed "build" rights to open the top of the me chest, and could then insert/remove items at will
Now anyone can open the top of the chest, but you need "withdraw" rights to extract, and "deposit" rights to insert.

AlgorithmX2
AlgorithmX2 reviewed Sep 27, 2014
View reviewed changes
src/main/java/appeng/block/storage/BlockChest.java
@@ -54,6 +54,7 @@ public boolean onActivated(World w, int x, int y, int z, EntityPlayer p, int sid
ICellHandler ch = AEApi.instance().registries().cell().getHandler( cell );

tg.openGui( p, ch, cell, side );

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wat?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo seems to be the fastest collector of whitespace changes :).

@thepaperpilot
Changed the way the problem is fixed.
6c9201d 
Now anyone can open ME chests, but if there is a security terminal on the
network, you must have withdraw or deposit permissions in order to extract or inject
items, respectively.
@thatsIch
Copy link
Member

Currently testing this.

@thatsIch
Copy link
Member

I am getting strange side effects, that I cant place blocks near the secured network. Access seems to work though.

@PlasmaPower
Copy link

@thatsIch That's weird, that really shouldn't happen. IDK how this code could make it do that.

@thepaperpilot
Copy link
Contributor Author

Do you have build permission?
If that's not the issue, does it occur without my code?

@thatsIch
Copy link
Member

@thepaperpilot have not tried it. I tested it on new Forge Server + 2 Clients just to make sure it has nothing to do with DevEnv. How did you test it?

@thepaperpilot
Copy link
Contributor Author

I used the default forge configurations for a server(in offline mode) and 2
clients (so I had a PlayerXXX and a PlayerYYY).
I then had one place the terminal and control permissions, and had the
other attempt to do various actions with various permissions.

After your comment about not being able to build, I confirmed (for myself)
that its the "build" permission that prevents you from adding blocks to the
network. (which is working as intended, I believe)

On Sat, Sep 27, 2014 at 1:07 PM, thatsIch notifications@github.com wrote:

@thepaperpilot https://github.com/thepaperpilot have not tried it. I
tested it on new Forge Server + 2 Clients just to make sure it has nothing
to do with DevEnv. How did you test it?

—
Reply to this email directly or view it on GitHub
#6 (comment)
.

-Anthony Lawn

@thatsIch
Copy link
Member

but it prevented me from putting down dirt blocks

@AlgorithmX2
Copy link
Contributor

New Number #79

@thatsIch thatsIch added this to the rv2 milestone Sep 27, 2014
@Cisien
Copy link
Contributor

Cisien commented Sep 27, 2014

I'm not experiencing any issues with this PR.

The only time i'm unable to place down blocks is when i right-click the chest/security station with the block of dirt. If I hold down shift while trying to place the block against the ME machine, it works fine.

I tested this with 2 retail accounts connected to 2 normal minecraft instances in a LAN game.

card config: http://paste.cisien.com/f/627bfe17.png
setup: http://paste.cisien.com/f/8fd7c8bd.png

http://paste.cisien.com/f/179045b2.png

@thepaperpilot
Copy link
Contributor Author

Me and Cisien tested this on a networked server, as well. Everything was working as intended. However, our original test was inside of spawn protection, and Cisien (who wasn't OP) couldn't place or break blocks.
I think that may have been the issue, since you said in IRC you could place blocks when you were OP-ed

@Cisien
Copy link
Contributor

Cisien commented Sep 27, 2014

I ran through as much as i could think of to test this on my local instances, as well as hopping on @thepaperpilot's server to validate, and didn't run into any issues.

Could it of been spawn protection causing you trouble, @thatsIch?

Cisien added a commit that referenced this pull request Sep 27, 2014
@Cisien
Merge pull request #6 from thepaperpilot/0880
e159298 
Fixed Bug: #79 - ME Chest can't be protected by ME Security Terminal.
@Cisien Cisien merged commit e159298 into AppliedEnergistics:master Sep 27, 2014
@thatsIch
Copy link
Member

@Cisien that might have been it. I did not know that there is spawn protection nowadays...

Elix-x pushed a commit to Elix-x/Applied-Energistics-2 that referenced this pull request Aug 26, 2016
@MoreThanHidden @Elix-x
Merge PR AppliedEnergistics#7 from MoreThanHidden/1.10-rv3-rendering …
4c4bdff 
…- Particle Texture Atlas Added

Merge PR AppliedEnergistics#7 from MoreThanHidden/1.10-rv3-rendering - Particle Texture Atlas Added.
Closes AppliedEnergistics#6.
yueh pushed a commit to yueh/Applied-Energistics-2 that referenced this pull request Sep 16, 2016
@shartte
Added block models for debug blocks. Fixes AppliedEnergistics#6.
73b9e83
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Self explanatory?
Projects
None yet
Milestone
rv2 - 1.7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thepaperpilot @AlgorithmX2 @thatsIch @PlasmaPower @Cisien