Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port forge's chunkloading api, so the spatial anchor works #6527

Closed
wants to merge 1 commit into from

Conversation

Mari023
Copy link
Contributor

@Mari023 Mari023 commented Sep 2, 2022

  • the spatial anchor's overlay doesn't render correctly
  • I am not quite sure with the licensing, the classes copied from forge all have their license header, but I am not sure about the patches I converted into mixins (+ an interface for some of the mixins)

@shartte
Copy link
Member

shartte commented Sep 2, 2022

Oh niiiiiiiiiiiiiiiiiiiiice.

It's not going to work though, since portaforgy is not part of the published mod artifact 😩

I wouldn't worry about the Mixins since you did rewrite them.

I would have expected this to be more code overall 🤔

@Technici4n
Copy link
Member

I am not quite sure with the licensing, the classes copied from forge all have their license header, but I am not sure about the patches I converted into mixins (+ an interface for some of the mixins)

Forge patches are CC0, no worries.

@shartte
Copy link
Member

shartte commented Sep 2, 2022 via email

@Technici4n
Copy link
Member

Hmmm, the Forge CLA says that Forge owns copyright over the patches and they are licensed under LGPL2.0 (wtf?).

image

@zurgeg
Copy link

zurgeg commented Mar 12, 2023

By the way, if forge's licensing ends up being incompatible, somebody made a chunkloader for Fabric licensed under CC0

@Technici4n
Copy link
Member

Superseded by #7011.

@Technici4n Technici4n closed this Apr 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2023
@Mari023 Mari023 deleted the chunkloading branch October 1, 2023 23:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants