add option to properly hide slot via texturepack #6561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shartte
reviewed
Sep 15, 2022
Comment on lines
328
to
338
| public void hideSlot(String semantic) { | ||
| if (isClientSide()) { | ||
| sendClientAction(HIDE_SLOT, semantic); | ||
| } | ||
| for (Slot s : getSlots(SlotSemantics.getOrThrow(semantic))) { | ||
| if (s instanceof AppEngSlot slot) { | ||
| slot.setSlotEnabled(false); | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't like adding new server interactions for resource packs, to be honest.
Why is it necessary to disable it on the server too?
There was a problem hiding this comment.
slots have to be disabled on the server to disable the shift click logic.
Technici4n
requested changes
Sep 16, 2022
Technici4n
approved these changes
Sep 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently only works with AppEngSlots that do NOT implement IOptional Slot
(Slots implementing IOptional slot override isSlotEnabled() with their own logic)