Do not connect pattern providers to interfaces on the same network #6842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technici4n
reviewed
Dec 19, 2022
| if (otherNode.getOwner() instanceof PatternProviderLogicHost) { | ||
| if (otherNode.getOwner() instanceof PatternProviderLogicHost | ||
| || (otherNode.getOwner() instanceof InterfaceLogicHost | ||
| && otherNode.getGrid().equals(mainNode.getGrid()))) { |
There was a problem hiding this comment.
Weird that this check didn't exist for pattern providers? Why shouldn't you be able to push to a pattern provider on a different network?
There was a problem hiding this comment.
I can't see myself why not, but I wasn't sure if there was any specific intent to disallowing any and all pattern providers from receiving other providers' inputs.
There was a problem hiding this comment.
Hmmm this might have been an intended recent change. @shartte does that ring a bell?
There was a problem hiding this comment.
No I don't think I changed that. At least not intentionally.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6820.