Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a different Shader get-method in Blitter.blit() #6923

Closed
wants to merge 4 commits into from
Closed

Use a different Shader get-method in Blitter.blit() #6923

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d679494
Use `getPositionTexShader` over `getPositionTexColorShader`
Lordfirespeed Feb 6, 2023
1328177
Merge branch 'master' into patch-1
Lordfirespeed May 7, 2023
ba2634c
Remove merge artifact
Lordfirespeed May 7, 2023
0558721
run spotlessApply
Lordfirespeed May 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use getPositionTexShader over getPositionTexColorShader 
Closes #6726 

I'm not 100% on what effect this has, however in Vanilla, `getPositionTexShader` returns a `ShaderInstance` created using the same resource location as `getPositionTexColorShader`, the only difference is the "vertex configuration".
  • Loading branch information
@Lordfirespeed
Lordfirespeed committed Feb 6, 2023
commit d67949436cf00c9c64245a75d202ed5e1ad82a91
2 changes: 1 addition & 1 deletion src/main/java/appeng/client/gui/style/Blitter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ public void blit(int zIndex) {
}

public void blit(PoseStack poseStack, int zIndex) {
RenderSystem.setShader(GameRenderer::getPositionTexColorShader);
RenderSystem.setShader(GameRenderer::getPositionTexShader);
RenderSystem.setShaderTexture(0, this.texture);

// With no source rectangle, we'll use the entirety of the texture. This happens rarely though.
Expand Down