OSC: Make plugin documentation complete #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already mentioned on the feedback page, but mentioning it above the list of control messages helps interpreting that list.
The rest of the docs do not use commas to separate the address from arguments, so remove them here. These commas seem to have been introduced first in commit 1138f1d (OSC: update OSC docs.) and were probably copy-pasted into docs added after that.
This makes the documentation complete by adding missing messages, clarifying some existind documenation and fixing `/select/plug_page` (address and parameter description were incorrect).
This was referenced Jun 29, 2024
pauldavisthefirst
pushed a commit
that referenced
this pull request
Jul 2, 2024
* OSC: Clarify control messages are also sent as feedback This is already mentioned on the feedback page, but mentioning it above the list of control messages helps interpreting that list. * OSC: Remove errant commas in addresses The rest of the docs do not use commas to separate the address from arguments, so remove them here. These commas seem to have been introduced first in commit 1138f1d (OSC: update OSC docs.) and were probably copy-pasted into docs added after that. * OSC: Fix and complete plugin operations and feedback This makes the documentation complete by adding missing messages, clarifying some existind documenation and fixing `/select/plug_page` (address and parameter description were incorrect).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some missing documentation about manipulating plugin (parameters), fixes some incorrectness and formatting inconsistencies. See individual commit messages for details.