fix(compiler): adding a guard on compileLetMutSet if we are passed so…

…mething that isn't a symbol as the name of the variable

CHANGELOG.md

@@ -33,6 +33,7 @@
 - `arkscript --version` and `arkscript --help` now output ArkScript version with the commit hash
 - `void Value::toString(std::ostream&, VM&)` now becomes `std::string Value::toString(VM&)`
 - removed `Node::operator<<` to replace it with `Node::debugPrint`
+- fixed a bug in the compiler where one could pass a non symbol to `let`, `mut` or `set`, resulting in a compiler crash
 
 ### Removed
 - removed unused `NodeType::Closure`

src/arkreactor/Compiler/Compiler.cpp

@@ -468,6 +468,9 @@ namespace Ark
 
     void Compiler::compileLetMutSet(const Keyword n, const Node& x, const int p)
     {
+        if (const auto sym = x.constList()[1]; sym.nodeType() != NodeType::Symbol)
+            throwCompilerError(fmt::format("Expected a symbol, got a {}", typeToString(sym)), sym);
+
         const std::string name = x.constList()[1].string();
         uint16_t i = addSymbol(x.constList()[1]);
         if (n != Keyword::Set)

tests/errors/compiler/let_no_sym.ark

@@ -0,0 +1,2 @@
+(let foo (fun () ()))
+(let (foo a b) 5)

tests/errors/compiler/let_no_sym.expected

@@ -0,0 +1,6 @@
+At ( @ 2:7
+    1 | (let foo (fun () ()))
+    2 | (let (foo a b) 5)
+      |       ^
+    3 |
+        let needs a symbol