fix(compiler): while nodes should have 3 children

CHANGELOG.md

@@ -45,6 +45,7 @@
 - fixed a bug in the compiler allowing the use of operators without any argument: `(+)`
 - fixed a bug in the vm during error reporting when a non-function was used as a function
 - refactored code inside the bytecode reader to promote code reuse
+- fixed a bug in the compiler generating invalid `while` nodes
 
 ### Removed
 - removed unused `NodeType::Closure`

src/arkreactor/Compiler/Compiler.cpp

@@ -475,15 +475,14 @@ namespace Ark
     {
         if (const auto sym = x.constList()[1]; sym.nodeType() != NodeType::Symbol)
             throwCompilerError(fmt::format("Expected a symbol, got a {}", typeToString(sym)), sym);
+        if (x.constList().size() != 3)
+            throwCompilerError("Invalid node ; if it was computed by a macro, check that a node is returned", x);
 
         const std::string name = x.constList()[1].string();
         uint16_t i = addSymbol(x.constList()[1]);
         if (n != Keyword::Set)
             addDefinedSymbol(name);
 
-        if (x.constList().size() != 3)
-            throwCompilerError("Invalid node ; if it was computed by a macro, check that a node is returned", x);
-
         // put value before symbol id
         // starting at index = 2 because x is a (let|mut|set variable ...) node
         for (std::size_t idx = 2, end = x.constList().size(); idx < end; ++idx)
@@ -499,6 +498,9 @@ namespace Ark
 
     void Compiler::compileWhile(const Node& x, const int p)
     {
+        if (x.constList().size() != 3)
+            throwCompilerError("Invalid node ; if it was computed by a macro, check that a node is returned", x);
+
         // save current position to jump there at the end of the loop
         std::size_t current = page(p).size();
         // push condition

tests/errors/compiler/invalid_while.ark

@@ -0,0 +1,3 @@
+(while ($ a b) {
+    (set acc (+ acc (@ src a)))
+    (set a (+ 1 a))})

tests/errors/compiler/invalid_while.expected

@@ -0,0 +1,7 @@
+At (while (begin (set acc (+ acc (@ src b))) (set b (+ 1 b)))) @ 1:1
+    1 | (while ($ a b) {
+      | ^~~~~~~~~~~~~~~~
+    2 |     (set acc (+ acc (@ src a)))
+      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
+    3 |     (set a (+ 1 a))})
+        Invalid node ; if it was computed by a macro, check that a node is returned