Redraw chessground only on window width change #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some mobile browsers, scrolling a page triggers a window resize event (due to the url bar hiding), which redraws the page (
resize_ground
) and resets the page position to the top. I've experienced this with Chrome on Android and Firefox on Android, don't know if this affects other browsers. Sinceresize_ground
only cares about width anyway, I think we can trigger this only on window resize when the width changes.Please let me know if this fix is acceptable, thanks!