Storing options in localstorage #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArneVogel
requested changes
Nov 30, 2022
assets/js/study.js
Outdated
| */ | ||
| function set_options_values() { | ||
| let move_delay = document.getElementById("move_delay_time"); | ||
| move_delay.innerHTML = move_delay_time; |
There was a problem hiding this comment.
Can you innerHTML -> innerText? I know we control the input but I still would feel better with innerText :)
There was a problem hiding this comment.
Absolutely. There it is.
|
Thanks a lot. I like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this one is a little simpler. I've changed so that the options are now stored in local storage. I had it prepared since before.
I changed the remaining two options that used a boolean to store the option to a translation key instead so all options follow the same pattern, and it was also easier to store a text string in local storage.
Also, another quirk. I think the value of key_move_(enabled|disabled) and review_(slow|fast) had been reversed so I changed them. For example, the text of key_move_enabled was "Jump to key move: off" so I changed it to "on" instead so that the translation key correctly conveys what it means. In toggle_key_move() there was a similar mix-up which undid the confusion with the translation key. So everything worked before but the boolean value was just the reverse of what the option said.
And added a fallback in the switch-cases just to be safe if an option change name in the future.
BTW, I've got this option prepared as well. Do you want it? I can put up a PR as soon as this one is merged.