Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(unix): Suppress environment variables manipulation errors #241

Merged
merged 28 commits into from
Dec 22, 2021
Merged

fix(unix): Suppress environment variables manipulation errors #241

merged 28 commits into from
Dec 22, 2021

Conversation

Ash258
Copy link
Owner

@Ash258 Ash258 commented Dec 8, 2021 •
edited
Loading

@Ash258 Ash258 added the debt Code quality issues label Dec 8, 2021
@Ash258 Ash258 added this to the 0.6.5 milestone Dec 8, 2021
@Ash258 Ash258 self-assigned this Dec 8, 2021
@Ash258 Ash258 changed the title fix(unix): Supress environment variables manipulation errors fix(unix): Suppress environment variables manipulation errors Dec 8, 2021
@Ash258
Copy link
Owner Author

Ash258 commented Dec 9, 2021

First successful, completed manifest installation on Debian 🎉

image

@Ash258
Copy link
Owner Author

Ash258 commented Dec 9, 2021

Update is fine too

image
image

@Ash258
Copy link
Owner Author

Ash258 commented Dec 9, 2021

Test multiple shells/distros

@Ash258
Copy link
Owner Author

Ash258 commented Dec 14, 2021

Only ZSH is problematic with double quote. Single quote works for all

image

@Ash258
Copy link
Owner Author

Ash258 commented Dec 14, 2021

Rework it and properly test proxy

@Ash258
Copy link
Owner Author

Ash258 commented Dec 14, 2021 •
edited
Loading

  • shovel bucket add
  • shovel status
  • shovel update fake out $previousCommit
  • shovel update

Proxy - Unix

  • bash
  • zsh
  • dash

NoProxy - Unix

  • bash
  • zsh
  • dash

Proxy - Windows

  • shovel
  • shovel.cmd

NoProxy - Windows

  • shovel
  • shovel.cmd

@Ash258 Ash258 marked this pull request as ready for review December 21, 2021 04:19
@Ash258 Ash258 merged commit 971a069 into NEW Dec 22, 2021
@Ash258 Ash258 deleted the unixExperiment branch December 22, 2021 09:38
howyay pushed a commit to howyay/Scoop-Core that referenced this pull request Jan 8, 2022
@Ash258
fix(unix): Suppress environment variables manipulation errors (Ash258…
ca4de57 
…#241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ash258 Ash258

Labels
debt Code quality issues
Projects
None yet
Milestone
0.6.5
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Ash258