Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird Importing Bug I found on WasmBoy #29

Closed
torch2424 opened this issue Feb 16, 2018 · 2 comments
Closed

Weird Importing Bug I found on WasmBoy #29

torch2424 opened this issue Feb 16, 2018 · 2 comments
Labels

Comments

@torch2424
Copy link
Contributor

Hello!

So here is that weird importing bug I found. So I made a branch with an exact commit on WasmBoy where I noticed that I am exporting a function from a file (wasm/memory/index.ts) from another file (wasm/memory/load.ts) that exports said function. I then tried to import the function into another random file (wasm/graphics/graphics.ts), and I get the following error:

screen shot 2018-02-15 at 8 11 50 pm

I have no clue what is causing this, but as you mentioned you don't mind looking into it :) Thanks for the help, and sorry if it is something dumb on my end haha!

dcodeIO added a commit that referenced this issue Feb 16, 2018
@dcodeIO
Copy link
Member

dcodeIO commented Feb 16, 2018

Thanks a lot! With the fix above the wasm build should now work in that branch.

Btw, is it OK for you if I'd mention wasmBoy on Twitter? So tempting.

goes play Tetris

@torch2424
Copy link
Contributor Author

The fix totally worked!

screen shot 2018-02-16 at 3 12 40 am
screen shot 2018-02-16 at 3 12 33 am

Thanks! That was super quick :)

And of course please do! I'd actually really appreciate it! it's far from done / shippable, there's still a lot to do, but it is coming together! :) I've been advocating for Assemblyscript with a few developer friends recently if I may say haha!

I also found one last REALLY weird bug. And it has to do with memory, so I opened an issue at #30, but feel free to close it if you are certain it's not on your end (it probably isn't)

@dcodeIO dcodeIO added the bug label Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants