Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bindings for performance.now() and document.* #2657

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Fix the bindings for performance.now() and document.* #2657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Generate wrapper binding functions for non-identifier imports 
This change should ensure performance.now() and document.foo() does not
break.
  • Loading branch information
@CountBleck
CountBleck committed Feb 26, 2023
commit ab678e7b90bb02857f2a6b79c3eb9c47011e529a
2 changes: 1 addition & 1 deletion src/bindings/js.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ export class JSBuilder extends ExportsWalker {
sb.push(escapeString(name, CharCode.DoubleQuote));
sb.push("\"");
}
if (isPlainFunction(signature, Mode.Import) && !code) {
if (isPlainFunction(signature, Mode.Import) && !code && isIdentifier(name)) {
sb.push(": (\n");
indent(sb, this.indentLevel + 1);
sb.push("// ");
Expand Down