-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dApp staking - try-state
checks implemented
#1331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipapandinas
added
dapps-staking
Dapps Staking
tests
If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc.
labels
Aug 20, 2024
ermalkaleci
previously approved these changes
Aug 22, 2024
Minimum allowed line rate is |
@ermalkaleci I removed an invariant check, can you re approve it? |
ermalkaleci
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dapps-staking
Dapps Staking
tests
If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This pull request enforces tests with
try-state
checks to ensure storage invariants are maintained.Closes #1294
Invariants
Below are all the invariants checked, grouped by storage items.
Invariants of active protocol storage items
PeriodInfo
] number in [ActiveProtocolState
] must always be greater than the number of elements in [PeriodEnd
].era
number andnext_era_start
block number are valid.Invariants of NextDAppId
NextDAppId
] must always be greater than or equal to the number of dapps in [IntegratedDApps
].NextDAppId
] must always be greater than or equal to the number of contracts in [ContractStake
].Invariants of IntegratedDApps
IntegratedDApps
] should not exceed the [T::MaxNumberOfContracts
] constant.Invariants of StaticTierParams and TierConfig
T::NumberOfTiers
] constant must always be equal to the number ofslot_distribution
,reward_portion
,tier_thresholds
in [StaticTierParams
].T::NumberOfTiers
] constant must always be equal to the number ofslots_per_tier
,reward_portion
,tier_thresholds
in [TierConfig
].Invariants of Ledger
Ledger
] accounts should yield the correct locked and stakes amounts compared to current era in [CurrentEraInfo
].Ledger
] for any account should not exceed the [T::MaxUnlockingChunks
] constant.Ledger
] should be greater than or equal to the [T::MinimumStakeAmount
] constant.Ledger
] should be greater than or equal to the [T::MinimumLockedAmount
] constant.Ledger
] should not exceed the [T::MaxNumberOfStakedContracts
] constant.Invariants of ContractStake
ContractStake
] should yield the correct staked amounts compared to current era in [CurrentEraInfo
]ContractStake
] should be greater than or equal to the [T::MinimumStakeAmount
] constant.Invariants of EraRewards
DAppTiers
] must also be stored in one of the span of [EraRewards
].EraRewards
] should be lower than or equal to the [T::EraRewardSpanLength
] constant.Check list