Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix revert command when running as parachain #1363

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix revert command when running as parachain #1363

merged 1 commit into from
Sep 16, 2024

Conversation

vedhavyas
Copy link
Contributor

Pull Request Summary
This PR updates the revert command when running as Parachain. This was not the case since previous code was expecting the grandpa set which doesn't exist when running as Parachain but works fine when running a local dev since we run the local dev as Solo chain with grandpa enabled

The change checks if chain_spec is dev,

  • if dev, then use grandpa set revert
  • if not, then simply revert the chain without grandpa set

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • added benchmarks & weights for any modified runtime logics.

@vedhavyas vedhavyas added astar Related to Astar client This PR/Issue is related to the topic “client”. parachain Parachain related issues. labels Sep 16, 2024
Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/inflation/src 89% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
precompiles/dapp-staking/src 90% 0%
chain-extensions/types/assets/src 0% 0%
pallets/price-aggregator/src 82% 0%
precompiles/dispatch-lockdrop/src 86% 0%
chain-extensions/types/unified-accounts/src 0% 0%
precompiles/xcm/src 71% 0%
chain-extensions/unified-accounts/src 0% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/dapp-staking/src/test 0% 0%
pallets/dapp-staking/src 83% 0%
precompiles/unified-accounts/src 100% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/unified-accounts/src 86% 0%
pallets/dapp-staking/rpc/runtime-api/src 0% 0%
pallets/ethereum-checked/src 74% 0%
primitives/src 57% 0%
precompiles/dapp-staking/src/test 0% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
precompiles/sr25519/src 64% 0%
pallets/collator-selection/src 92% 0%
pallets/collective-proxy/src 86% 0%
pallets/dapp-staking/src/benchmarking 98% 0%
pallets/xc-asset-config/src 50% 0%
precompiles/assets-erc20/src 78% 0%
pallets/static-price-provider/src 85% 0%
pallets/vesting-mbm/src 89% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
primitives/src/xcm 65% 0%
Summary 79% (3726 / 4730) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vedhavyas vedhavyas merged commit 82b60ce into master Sep 16, 2024
9 of 11 checks passed
@vedhavyas vedhavyas deleted the revert branch September 16, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar client This PR/Issue is related to the topic “client”. parachain Parachain related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants